Last modified: 2014-02-25 11:26:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60556, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58556 - Use Bugzilla hooks instead of custom template for fix for bug 40244
Use Bugzilla hooks instead of custom template for fix for bug 40244
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
wmf-deployment
All All
: Normal enhancement (vote)
: ---
Assigned To: Andre Klapper
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-17 00:14 UTC by Andre Klapper
Modified: 2014-02-25 11:26 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Andre Klapper 2013-12-17 00:14:26 UTC
https://git.wikimedia.org/blob/wikimedia/bugzilla/modifications.git/HEAD/template/en/custom/list/table.html.tmpl only exists for bug 40244. Kill the file and create http://git.wikimedia.org/blob/wikimedia/bugzilla/modifications.git/HEAD/extensions/Wikimedia/template/en/default/hook/list/table-before_table.html.tmpl with the one-liner content:
  [% abbrev.product.maxlength = 13 %]

See http://www.bugzilla.org/docs/4.4/en/html/api/Bugzilla/Extension.html for more information.

Advantage: When upgrading we don't need to sync the code in the file /template/en/custom/ anymore with code in the file /template/en/default.
Comment 1 Gerrit Notification Bot 2014-02-19 13:27:45 UTC
Change 114145 had a related patch set uploaded by Aklapper:
Replace custom template file by using existing Bugzilla hook

https://gerrit.wikimedia.org/r/114145
Comment 2 Gerrit Notification Bot 2014-02-25 00:19:14 UTC
Change 114145 merged by Dzahn:
Replace custom template file by using existing Bugzilla hook

https://gerrit.wikimedia.org/r/114145
Comment 3 Andre Klapper 2014-02-25 11:26:08 UTC
Thanks! Things still work on buglist.cgi, hence closing as FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links