Last modified: 2014-02-28 23:41:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60586, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58586 - VisualEditor: Computed href in Firefox normalises ' ' to '%20'
VisualEditor: Computed href in Firefox normalises ' ' to '%20'
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-17 19:15 UTC by Ed Sanders
Modified: 2014-02-28 23:41 UTC (History)
7 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2013-12-17 19:15:53 UTC
This causes the test 'document with meta elements: data' in ve.dm.MWConverter to fail. Not sure if it is any more serious than that.
Comment 1 Bartosz Dziewoński 2013-12-17 19:40:00 UTC
A space is not a valid character in an URL, it must always be percent-encoded. https://en.wikipedia.org/wiki/URL#List_of_allowed_URL_characters
Comment 2 Gabriel Wicke 2013-12-20 17:12:41 UTC
(In reply to comment #1)
> A space is not a valid character in an URL, it must always be
> percent-encoded.
> https://en.wikipedia.org/wiki/URL#List_of_allowed_URL_characters

Are we talking about HTTP or HTML here? If it is HTML, then I'd suggest looking at the relevant HTML5 spec.
Comment 3 Gabriel Wicke 2013-12-20 18:13:23 UTC
(In reply to comment #0)
> This causes the test 'document with meta elements: data' in ve.dm.MWConverter
> to fail. Not sure if it is any more serious than that.

Are you comparing a HTML serialization or the DOM attribute? A diff in the former is fine, but a diff in the latter would be a bug.
Comment 4 Gabriel Wicke 2013-12-20 20:51:52 UTC
(In reply to comment #3)
> (In reply to comment #0)
> > This causes the test 'document with meta elements: data' in ve.dm.MWConverter
> > to fail. Not sure if it is any more serious than that.
> 
> Are you comparing a HTML serialization or the DOM attribute? A diff in the
> former is fine, but a diff in the latter would be a bug.

Actually, a diff in the *percent-decoded* DOM href attribute would be a bug.

We decode all hrefs in the serializer, so to us it makes no difference if it is encoded as %20 or a literal space in HTML.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links