Last modified: 2014-02-12 15:14:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60591, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58591 - Don't use potentially undefined constants in namespace file


Summary:	Don't use potentially undefined constants in namespace file

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	GWToolset (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-17 20:41 UTC by Sam Reed (reedy)
Modified:	2014-02-12 15:14 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2013-12-17 20:41:45 UTC

Otherwise we get warnings in GWToolset.namespaces.php during scap

Notice: Use of undefined constant NS_GWTOOLSET - assumed 'NS_GWTOOLSET' in /a/common/php-1.23wmf7/extensions/GWToolset/GWToolset.namespaces.php on line 12
PHP Notice:  Use of undefined constant NS_GWTOOLSET_TALK - assumed 'NS_GWTOOLSET_TALK' in /a/common/php-1.23wmf7/extensions/GWToolset/GWToolset.namespaces.php on line 13


Explicitly use numbers, or add if !defined to the top of the file

if ( !defined( 'NS_GWTOOLSET' ) ) {
	define( 'NS_GWTOOLSET', 490 );
	define( 'NS_GWTOOLSET_TALK', NS_GWTOOLSET + 1 );
}

Comment 1 Gerrit Notification Bot 2013-12-18 11:28:48 UTC

Change 102423 had a related patch set uploaded by Dan-nl:
adding additional namespace test

https://gerrit.wikimedia.org/r/102423

Comment 2 Gerrit Notification Bot 2013-12-18 17:49:46 UTC

Change 102423 merged by jenkins-bot:
adding namespaces as numeric values to GWToolset.namespaces.php and simplifying the defined test in GWToolset.php

https://gerrit.wikimedia.org/r/102423

Comment 3 dan 2014-01-08 20:41:16 UTC

sam,

the patch has been merged into the master branch and deployed to Commons.

please close this ticket if you’re satisfied with the results. if not, please
indicate what else needs to be addressed.

Comment 4 Andre Klapper 2014-02-12 15:14:37 UTC

No feedback - Closing as per comment 3.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links