Last modified: 2014-05-13 04:07:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60626, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58626 - Remove user ID from user preferences output
Remove user ID from user preferences output
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.24rc
All All
: Normal enhancement (vote)
: 1.24.0 release
Assigned To: Kunal Mehta (Legoktm)
: design
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-18 07:39 UTC by MZMcBride
Modified: 2014-05-13 04:07 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2013-12-18 07:39:58 UTC
Currently [[Special:Preferences]] shows a user his or her internal user ID. I'm not sure it makes sense to expose this in the user interface. It's an internal implementation detail. Plus on wikis with CentralAuth/unified login, there's additional complexity (i.e., each user has a global user ID and a local user ID on a particular wiki).

The API should expose and allow the use of a user's ID and there are separate bugs about that. This bug report is focused purely on the user interface.

Looking at how other software/sites handle this may make sense. For example, I don't think Facebook or Twitter or LinkedIn or Google Apps readily expose user IDs (apart from URLs, though those also have trended away from exposing user IDs).

This came up again in the context of <https://gerrit.wikimedia.org/r/101221>. I'm filing this as an unconfirmed bug. Any input welcome.
Comment 1 Jared Zimmerman (WMF) 2013-12-18 07:46:48 UTC
I'd recommend putting this in the tracking bug "things to remove from prefs" after confirming there is some secondary access to the information via some other logical means like an API or OAuth.
Comment 2 Kunal Mehta (Legoktm) 2013-12-18 07:49:54 UTC
(In reply to comment #1)
> I'd recommend putting this in the tracking bug "things to remove from prefs"
> after confirming there is some secondary access to the information via some
> other logical means like an API or OAuth.

It is exposed via the API: https://www.mediawiki.org/w/api.php?action=query&meta=userinfo&format=jsonfm or https://www.mediawiki.org/w/api.php?action=query&list=users&ususers=Legoktm&format=jsonfm
Comment 3 Bawolff (Brian Wolff) 2013-12-18 18:37:33 UTC
This could probably be removed. I can't think of a reason a user would need to know this. OTOH I also don't really see it hurting anyone either
Comment 4 Bawolff (Brian Wolff) 2013-12-18 18:51:20 UTC
After several applications of git blame, it appears that showing the user id on Special:Preferences goes all the way back to the beginning of phase3, as it is present in d82c14fb4fbac
Comment 5 MZMcBride 2013-12-18 22:08:47 UTC
(In reply to comment #4)
> After several applications of git blame, it appears that showing the user id
> on Special:Preferences goes all the way back to the beginning of phase3, as it
> is present in d82c14fb4fbac

I think you may be mis-reading? As far as I can tell, the user ID _appearing_ at [[Special:Preferences]] dates back to r11284 (October 2005).
Comment 6 Steven Walling 2013-12-19 01:14:52 UTC
(In reply to comment #3)
> This could probably be removed. I can't think of a reason a user would need
> to
> know this. OTOH I also don't really see it hurting anyone either

+1

This is too technical to be understandable to most users, and I don't understand why we expose it. Technically your user_id is public information just like your username, but it seems odd to put it in your preferences.
Comment 7 Bawolff (Brian Wolff) 2013-12-19 01:28:10 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > After several applications of git blame, it appears that showing the user id
> > on Special:Preferences goes all the way back to the beginning of phase3, as it
> > is present in d82c14fb4fbac
> 
> I think you may be mis-reading? As far as I can tell, the user ID _appearing_
> at [[Special:Preferences]] dates back to r11284 (October 2005).

Before that it appears to have been output by the prefslogintext, which had the content:

 "You are logged in as \"$1\".
Your internal ID number is $2.

See [[Project:User preferences help]] for help deciphering the options.",
Comment 8 MZMcBride 2013-12-19 03:16:25 UTC
(In reply to comment #7)

You're too smart. :-(  Thanks for the great catch.

I dug a bit further. It looks like this pre-dates phase3, dating back to r403 (May 2002), later modified in r766 (September 2002).
Comment 9 MZMcBride 2013-12-19 03:39:56 UTC
(In reply to comment #8)

Continuing to dig, this dates back to at least r15 (September 2001) in trunk/phpwiki/fpw/specialPages.php:

---
$ret .= "Your internal ID is $user->id.</b><br>\n";
---
Comment 10 Amir E. Aharoni 2014-05-09 08:26:15 UTC
So now that we dug it up and found that it was probably some kind of a debug printout, can we finally decide to remove it? :)
Comment 11 Gerrit Notification Bot 2014-05-12 04:51:15 UTC
Change 132916 had a related patch set uploaded by Legoktm:
Remove user id from Special:Preferences

https://gerrit.wikimedia.org/r/132916
Comment 12 Gerrit Notification Bot 2014-05-13 03:44:20 UTC
Change 132916 merged by jenkins-bot:
Remove user id from Special:Preferences

https://gerrit.wikimedia.org/r/132916

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links