Last modified: 2013-12-21 20:39:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60645, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 58645 - Flow: Merge RecentChanges & Contributions' formatters extend from 1 same base class
Flow: Merge RecentChanges & Contributions' formatters extend from 1 same base...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-18 14:44 UTC by Matthias Mullie
Modified: 2013-12-21 20:39 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthias Mullie 2013-12-18 14:44:59 UTC 
Title is self-explanatory. They share a lot of functionality.

Implementation ideas:
Contributions was the last one to be build, so re-used a lot from RecentChanges. Doing so, Most methods were updated to receive/return different parameters.
We should probably be able to re-use most utility methods as they are in Contributions/Formatter (and get rid of the of RC), with only some minor changes to RC's main format function.
Comment 1 Bingle 2013-12-18 14:48:24 UTC 
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/630, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2013-12-19 13:56:09 UTC 
Change 102674 had a related patch set uploaded by Matthias Mullie:
(bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class

https://gerrit.wikimedia.org/r/102674
Comment 3 Gerrit Notification Bot 2013-12-20 18:06:37 UTC 
Change 102674 merged by jenkins-bot:
(bug 58645) Merge RecentChanges & Contributions' formatters extend from 1 same base class

https://gerrit.wikimedia.org/r/102674
Comment 4 Tomasz W. Kozlowski 2013-12-21 20:39:59 UTC 
Patch got merged, so closing the bug. Please reopen if that's not the case.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links