Last modified: 2014-02-18 17:52:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60653, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 58653 - Move 'X' Icon to upper right corner in Media Viewer
Move 'X' Icon to upper right corner in Media Viewer
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Mark Holmquist
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-12-18 18:48 UTC by Fabrice Florin
Modified: 2014-02-18 17:52 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Fabrice Florin 2013-12-18 18:48:24 UTC 
The 'X' close icon in the Media Viewer is now shown at the top right corner of the image, even if there is plenty of room in the browser window around it. This unnecessarily clutters the image.

Instead, we should showin the 'X' icon at the top right corner of the browser window -- above the 'Next' right arrow. 

(Also note that either icon should not be right against the edge, but a few pixels away from it, as recommended by Pau Giner.)
Comment 1 MZMcBride 2013-12-25 01:43:50 UTC 
A mock would be helpful here.
Comment 2 Mark Holmquist 2013-12-27 19:57:05 UTC 
I'll take this one, particularly because I know what they're talking about and it's high priority for us.
Comment 3 Gerrit Notification Bot 2013-12-27 20:23:02 UTC 
Change 104131 had a related patch set uploaded by MarkTraceur:
Move 'x' button, shift arrows away from screen edges

https://gerrit.wikimedia.org/r/104131
Comment 4 Gerrit Notification Bot 2013-12-30 22:03:54 UTC 
Change 104131 merged by jenkins-bot:
Move 'x' button, shift arrows away from screen edges

https://gerrit.wikimedia.org/r/104131
Comment 5 Andre Klapper 2014-02-17 19:30:48 UTC 
Assuming this bug is FIXED as patch in comment 4 was merged.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.
Comment 6 Mark Holmquist 2014-02-18 17:52:48 UTC 
Confirmed, thanks Andre.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links