Last modified: 2014-09-03 14:57:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60696, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58696 - Flow: It's too easy to accidentally edit when logged-out
Flow: It's too easy to accidentally edit when logged-out
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-19 17:55 UTC by Oliver Keyes
Modified: 2014-09-03 14:57 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Oliver Keyes 2013-12-19 17:55:01 UTC
Not sure if we can do anything about this, but: with the normal wiki process it goes article - edit window - save. It's really easy to tell if you get coincidentally logged-out as you're trying to edit, because they're all different pages and so the interface changes.

With Flow, article and edit window are the same page; you can get logged-out while reading and leave a comment without the interface warning you. I'm not sure if there's anything we can do about that, but is there any way we could display a warning? The alternative is a potential increase to OS work of unknown amount.
Comment 1 Bingle 2013-12-19 18:00:33 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/640, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Matthias Mullie 2013-12-19 19:03:06 UTC
For the case of "I'm logged in, so interface shows my name; but I take too long - then submit and apparently was no longer logged in (session expired)":

When submitting the post, we could fetch user id from JS (mw.config.get( 'wgUserId' )), submit it along with the post content being submitted. When validating post submission, we can check if against request context user. If they don't match, we can respond with an error (similar to edit conflict) to inform the user they're no longer logged in. They could then either submit anyway, or copy the content, log in again, and re-submit.

Just one idea.
Comment 3 Helder 2014-01-31 10:54:48 UTC
(In reply to comment #2)
> For the case of "I'm logged in, so interface shows my name; but I take too
> long
> - then submit and apparently was no longer logged in (session expired)":
> 
> When submitting the post, we could fetch user id from JS (mw.config.get(
> 'wgUserId' )), submit it along with the post content being submitted. When
> validating post submission, we can check if against request context user. If
> they don't match, we can respond with an error (similar to edit conflict) to
> inform the user they're no longer logged in. They could then either submit
> anyway, or copy the content, log in again, and re-submit.
> 
> Just one idea.

+1

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links