Last modified: 2014-01-30 01:36:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60728, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58728 - Echo flyout broken in CologneBlue skin
Echo flyout broken in CologneBlue skin
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-20 05:08 UTC by Kunal Mehta (Legoktm)
Modified: 2014-01-30 01:36 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (451.98 KB, image/png)
2013-12-20 05:08 UTC, Kunal Mehta (Legoktm)
Details

Description Kunal Mehta (Legoktm) 2013-12-20 05:08:59 UTC
Created attachment 14145 [details]
Screenshot

See the attache screenshot. Because the 0 icon is on the left side, part of the flyout is chopped off.

As a temporary fix, I think we should just disable the flyout on the CologneBlue skin. Eventually it would be cool to have the flyout work, but that might be a lot of work.
Comment 1 Bartosz Dziewoński 2013-12-21 12:29:29 UTC
Sounds reasonable to me. We should probably only show the flyout if the badge appears within, say, top 20% of screen height.

(But we could get the "pokey" to be dynamic, moving the whole box left or right to always fit on-screen.)
Comment 2 Gerrit Notification Bot 2013-12-21 13:25:50 UTC
Change 103099 had a related patch set uploaded by Bartosz Dziewoński:
Make sure the overlay is visible, even if the badge is near the edge

https://gerrit.wikimedia.org/r/103099
Comment 3 Gerrit Notification Bot 2013-12-21 13:26:03 UTC
Change 103100 had a related patch set uploaded by Bartosz Dziewoński:
Don't show the overlay if the badge is not near the top of the window

https://gerrit.wikimedia.org/r/103100
Comment 4 Gerrit Notification Bot 2014-01-12 14:06:16 UTC
Change 103099 merged by jenkins-bot:
Make sure the overlay is visible, even if the badge is near the edge

https://gerrit.wikimedia.org/r/103099
Comment 5 Gerrit Notification Bot 2014-01-30 01:36:19 UTC
Change 103100 merged by jenkins-bot:
Don't show the overlay if the badge is not near the top of the window

https://gerrit.wikimedia.org/r/103100

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links