Last modified: 2014-03-21 23:41:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60747, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58747 - Editing (or any action) a post hides all it's (descendant) replies
Editing (or any action) a post hides all it's (descendant) replies
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-20 15:42 UTC by Matthias Mullie
Modified: 2014-03-21 23:41 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Mullie 2013-12-20 15:42:20 UTC
After submitting an action via JS, the api request responds with rendered HTML, which JS then replaces the old HTML with.

However, loadRequestedRevision (in Topic.php) doesn't load the full tree here, but only the post & root post (= topic). So, no children. It replaces the post and all of it's child replies, by just the new post HTML (without child replies)

Either we make sure loadRequestedRevision always loads the full tree, or we change JS to make sure only the post (and no children) are replaces (a little tricky because they're nested inside the post's DOM)
Comment 1 Bingle 2013-12-20 15:48:23 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/646, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2014-01-02 01:48:41 UTC
Change 104910 had a related patch set uploaded by Werdna:
When executing an action on a post, just replace the .flow-post, not the whole .flow-post-container.

https://gerrit.wikimedia.org/r/104910
Comment 3 Gerrit Notification Bot 2014-01-03 00:27:47 UTC
Change 104910 merged by jenkins-bot:
When executing an action on a post, just replace the .flow-post, not the whole .flow-post-container.

https://gerrit.wikimedia.org/r/104910

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links