Last modified: 2013-12-21 17:27:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58779 - "Edit count" feature is broken (again) on Commons
"Edit count" feature is broken (again) on Commons
Status: RESOLVED FIXED
Product: Wikimedia Labs
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Cyberpower678
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-21 02:37 UTC by Pete F
Modified: 2013-12-21 17:27 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Pete F 2013-12-21 02:37:31 UTC
When trying to use the edit count feature on Wikimedia Commons (for example, this URL for my account: http://tools.wmflabs.org/xtools/pcount/index.php?name=Peteforsyth&lang=commons&wiki=wikimedia ) one gets no meaningful results, but a page full of error messages, like this:

Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189

(followed by identical statements about different offset and line numbers).

This problem happened a few months ago, and was fixed; if I recall correctly, it had something to do with a new namespace being added on Commons. Is it possible to update the edit count tool so that it's not so sensitive to name space changes?
Comment 1 Bawolff (Brian Wolff) 2013-12-21 02:39:46 UTC
btw, 460 = Campaign namespace
Comment 2 Pete F 2013-12-21 02:42:12 UTC
I found the prior bug: 53494 (and assigned accordingly)
Comment 3 Cyberpower678 2013-12-21 13:42:53 UTC
(In reply to comment #0)
> When trying to use the edit count feature on Wikimedia Commons (for example,
> this URL for my account:
> http://tools.wmflabs.org/xtools/pcount/index.
> php?name=Peteforsyth&lang=commons&wiki=wikimedia
> ) one gets no meaningful results, but a page full of error messages, like
> this:
> 
> Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189
> 
> (followed by identical statements about different offset and line numbers).
> 
> This problem happened a few months ago, and was fixed; if I recall correctly,
> it had something to do with a new namespace being added on Commons. Is it
> possible to update the edit count tool so that it's not so sensitive to name
> space changes?

Unfortunately no.  Everytime a namespace is added, the edit counter will break because it is missing data for that namespace.  What's missing is usually a color definition to assign the namespace to for graphing purposes.  I'll have it fixed in just a few minutes.
Comment 4 Cyberpower678 2013-12-21 13:50:00 UTC
But I'm starting to run out of distinctively different colors. :p
Comment 5 Bawolff (Brian Wolff) 2013-12-21 17:16:16 UTC
(In reply to comment #3)
> (In reply to comment #0)
> > When trying to use the edit count feature on Wikimedia Commons (for example,
> > this URL for my account:
> > http://tools.wmflabs.org/xtools/pcount/index.
> > php?name=Peteforsyth&lang=commons&wiki=wikimedia
> > ) one gets no meaningful results, but a page full of error messages, like
> > this:
> > 
> > Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189
> > 
> > (followed by identical statements about different offset and line numbers).
> > 
> > This problem happened a few months ago, and was fixed; if I recall correctly,
> > it had something to do with a new namespace being added on Commons. Is it
> > possible to update the edit count tool so that it's not so sensitive to name
> > space changes?
> 
> Unfortunately no.  Everytime a namespace is added, the edit counter will
> break
> because it is missing data for that namespace.  What's missing is usually a
> color definition to assign the namespace to for graphing purposes.  I'll have
> it fixed in just a few minutes.

Surely it could handle the situation more gracefully (e.g. make all non-specified namespaces white or if unspecified take a hash of the namespace and derrive the colour from that)
Comment 6 Cyberpower678 2013-12-21 17:27:09 UTC
(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #0)
> > > When trying to use the edit count feature on Wikimedia Commons (for example,
> > > this URL for my account:
> > > http://tools.wmflabs.org/xtools/pcount/index.
> > > php?name=Peteforsyth&lang=commons&wiki=wikimedia
> > > ) one gets no meaningful results, but a page full of error messages, like
> > > this:
> > > 
> > > Notice: Undefined offset: 490 in /data/project/xtools/Graph.php on line 189
> > > 
> > > (followed by identical statements about different offset and line numbers).
> > > 
> > > This problem happened a few months ago, and was fixed; if I recall correctly,
> > > it had something to do with a new namespace being added on Commons. Is it
> > > possible to update the edit count tool so that it's not so sensitive to name
> > > space changes?
> > 
> > Unfortunately no.  Everytime a namespace is added, the edit counter will
> > break
> > because it is missing data for that namespace.  What's missing is usually a
> > color definition to assign the namespace to for graphing purposes.  I'll have
> > it fixed in just a few minutes.
> 
> Surely it could handle the situation more gracefully (e.g. make all
> non-specified namespaces white or if unspecified take a hash of the namespace
> and derrive the colour from that)

I could, but that would make the problem go unnoticed.  Also to have it set its own color could cause it to make extremely similar colors.  Making the pi chart harder to read.  I'd like to ensure the pi chart could be read by setting my own colors and making sure that they are different from each other.  When the edit counter was still on toolserver, error suppression was switched on, suppressing all error messages.  Hardly anybody noticed any issues.  The edit counter was really broken though.  So keeping error suppression off is the best way to make sure things are fixed and programmed correctly.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links