Last modified: 2014-09-04 14:59:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60800, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58800 - Flow: Topic bar CSS defeats its active button behavior
Flow: Topic bar CSS defeats its active button behavior
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-21 14:47 UTC by spage
Modified: 2014-09-04 14:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2013-12-21 14:47:14 UTC
People complain about clicking the topic bar to collapse/expan, e.g. bug 58661, partly because it doesn't act like a button, .  We intend the topic bar should act like a giant button by giving it the class .mw-ui-button, so it gets the beveled bottom edge on hover.  However, it doesn't darken on click because its gray background color from .flow-titlebar background has a greater specificity than the dark gray background in .mw-ui-button:active styling.

The fix might be to give flow-titlebar its own :active background color, to somehow turn off its gray background when active, or to jiggle the specificity so mw-ui-button:active wins.  It doesn't help that Flow loads its CSS twice, once with addModuleStyles() and then again with addModules(); this is wrong and wasteful, though I'm not sure if CSS actually loads twice.

Also, the flow title-bar div doesn't have a title="Click to collapse/expand" to hint at its behavior
Comment 1 Bingle 2013-12-21 14:48:39 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/649, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Krinkle 2014-02-20 04:35:27 UTC
(In reply to spage from comment #0)
> [..] so mw-ui-button:active wins.  It doesn't help that Flow loads
> its CSS twice, once with addModuleStyles() and then again with addModules();
> this is wrong and wasteful, though I'm not sure if CSS actually loads twice.
> 

It is loaded, parsed and applied twice. See bug 61305.
Comment 3 Matthias Mullie 2014-09-04 14:59:46 UTC
What should the :active color be?

Also: since this bug report, we've added the collapse toggles, so this specific issue might be less important (now that we have those other buttons to toggle the topics)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links