Last modified: 2014-01-22 15:26:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60850, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58850 - wbmergeitems isn't merging claims properly
wbmergeitems isn't merging claims properly
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Highest major (vote)
: ---
Assigned To: Wikidata bugs
backlog
: need-volunteer
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-21 23:36 UTC by Marius Hoch
Modified: 2014-01-22 15:26 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Marius Hoch 2013-12-21 23:36:17 UTC
The merge item api module isn't merging claims correctly (example: https://www.wikidata.org/w/index.php?diff=95501306&oldid=88167854).

These merges were probably hit of from client's page connector, which sets ignoreconflicts=label|description (that *shouldn't* matter).

This is probably rather important as the client uses the API module per default without even telling the user that it's about to perform a merge.
Comment 1 Addshore 2014-01-07 13:42:05 UTC
This is per a design choice by Denny, I had originally written code that merged claims as I think you are expecting but the decision was made to not do this.
Comment 2 Marius Hoch 2014-01-07 13:47:31 UTC
(In reply to comment #1)
> This is per a design choice by Denny, I had originally written code that
> merged
> claims as I think you are expecting but the decision was made to not do this.

I feared that would come up as cause... can you remember the exact thing Denny said? Does it apply to all cases or... (there are quite some different examples for that, some simpler, some more complex ...) ? If this applies to all cases, I guess we want to WONTFIX this bug.
Comment 3 Addshore 2014-01-07 13:57:19 UTC
I seems to remember it applying for all cases but will wait for denny to respond
Comment 4 denny vrandecic 2014-01-07 21:17:18 UTC
When merging two items, a statement from item 1 and a statement from item 2 can be merged if the claims are completely identical, i.e. if all qualifiers are identical and if the main snaks are identical. In particular, if only one claim has a qualifier and the other one does not, they can not be merged. If the set of qualifiers is overlapping, but not identical, they cannot be merged.

Merging in this case means that the claim stays, but all references can be added on the same claim. So if there is a statement with claim X and reference A on item 1, and a statement with claim X and reference B on item 2, the merged item can have a statement with claim X and references A and B.

Any difference in the claim though forbids merging, i.e.

population 23
reference A

and

population 23
method counting
reference B

can not be merged.
Comment 5 Gerrit Notification Bot 2014-01-11 16:29:57 UTC
Change 106897 had a related patch set uploaded by Addshore:
Merge References for Statements in wbmergeitems

https://gerrit.wikimedia.org/r/106897
Comment 6 Bene* 2014-01-17 20:44:56 UTC
Please note that this will be a problem when we want to turn one item into a redirect after merging because this item *must* be empty after merging so that no data is lost. Perhaps we need some mechanism where the user has to decide which statements should be used in question.
Comment 7 Gerrit Notification Bot 2014-01-20 21:42:39 UTC
Change 106897 merged by Jeroen De Dauw:
Merge References for Statements in wbmergeitems

https://gerrit.wikimedia.org/r/106897

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links