Last modified: 2014-11-20 00:19:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60886, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58886 - Image tag for enwiki project logo should specify dimensions and use a stable URL
Image tag for enwiki project logo should specify dimensions and use a stable URL
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized minor
: ---
Assigned To: Nobody - You can work on this!
: easy, performance
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-23 09:46 UTC by Ori Livneh
Modified: 2014-11-20 00:19 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ori Livneh 2013-12-23 09:46:04 UTC
The logo in the footer of the mobile version of the English Wikipedia does not specify dimensions. It is styled to have a height of 1em. To lay it out, the browser has to fetch the image, determine its pixel size, and scale it to match the CSS, which slows down rendering.

It is also served from a volatile URL which includes the branch name. You might want to use "static-current" instead (i.e., <https://bits.wikimedia.org/static-current/extensions/MobileFrontend/images/logo-copyright-en.png>)
Comment 1 Bingle 2013-12-23 09:55:29 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1574
Comment 2 Jon 2013-12-24 01:22:13 UTC
I think it also meant to be slightly bigger to look nice on retina displays.
I guess what you are saying is rather than specifying the height in ems we specify it in pixels?

In terms of volatile URL, this is all done in config...

I'm guessing the offending line is:
$wmgMFCustomLogos['copyright'] = str_replace( '{wgExtensionAssetsPath}', $wgExtensionAssetsPath, $wmgMFCustomLogos['copyright'] );

Would it be better to use an absolute URL here? Considering this is on every page we should be careful where this image is hosted...
Comment 3 Jon 2014-01-08 01:32:50 UTC
Waiting on a response from Ori
Comment 4 Juliusz Gonera 2014-06-11 21:29:47 UTC
Ori, is this really a performance issue? I can't imagine one image slowing down rendering significantly.
Comment 5 Ori Livneh 2014-06-11 21:37:55 UTC
(In reply to Juliusz Gonera from comment #4)
> Ori, is this really a performance issue? I can't imagine one image slowing
> down rendering significantly.

Those are two different questions. It's worth the effort to fix, if that's what you're asking.

https://developers.google.com/speed/docs/best-practices/rendering#SpecifyImageDimensions
http://www.feedthebot.com/pagespeed/image-dimensions.html
Comment 6 Jon 2014-11-17 23:57:24 UTC
So it sounds like we just need to use getimagesize and add the image width and height to SkinMinerva::getSitename function

Should be easy to do so let's just do it.
Comment 7 Bingle 2014-11-18 00:00:25 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/wNb5TP4s
Comment 8 Gerrit Notification Bot 2014-11-18 19:55:06 UTC
Change 174218 had a related patch set uploaded by Bmansurov:
Add footer logo dimensions

https://gerrit.wikimedia.org/r/174218
Comment 9 Gerrit Notification Bot 2014-11-19 00:22:47 UTC
Change 174218 merged by jenkins-bot:
Add footer logo dimensions

https://gerrit.wikimedia.org/r/174218
Comment 10 Gerrit Notification Bot 2014-11-19 22:59:22 UTC
Change 174585 had a related patch set uploaded by Kaldari:
Adding Wikipedia wordmark for mobile and switching to it

https://gerrit.wikimedia.org/r/174585
Comment 11 Gerrit Notification Bot 2014-11-20 00:05:19 UTC
Change 174585 merged by jenkins-bot:
Adding Wikipedia wordmark for mobile and switching to it

https://gerrit.wikimedia.org/r/174585
Comment 12 Ryan Kaldari 2014-11-20 00:19:51 UTC
Fixed on test.wiki. Should go out to en.wiki soon.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links