Last modified: 2014-05-29 23:00:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60935, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 58935 - Flow: Paging limit doesn't account for moderated topic
Flow: Paging limit doesn't account for moderated topic
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 65897 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-24 13:59 UTC by Matthias Mullie
Modified: 2014-05-29 23:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (174.54 KB, image/png)
2014-05-27 21:25 UTC, Quiddity
Details

Description Matthias Mullie 2013-12-24 13:59:13 UTC
Hidden/deleted/suppressed topics that the user can't see, are filtered out.
Paging picks a certain # of topics and filters those out afterwards.
Instead of returning 10 posts, only 7 may be returned if 3 of them are moderated  (and the user doesn't have permissions to see those)

This is a really minor issue, not worth spending much time on (imo).
We should just make sure that if *all* <limit> posts are moderated (and none are returned), the infinite scroll fires again.
Comment 1 Bingle 2013-12-24 14:12:24 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/656, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2014-01-08 14:14:41 UTC
Change 106249 had a related patch set uploaded by Matthias Mullie:
Immediately trigger new scroll event after adding infinite scoll content

https://gerrit.wikimedia.org/r/106249
Comment 3 Matthias Mullie 2014-01-08 14:15:58 UTC
Above patch fixes the problem that infinite scroll doesn't fire again if no new visible feedback was loaded (because all of it was deleted)
Comment 4 Gerrit Notification Bot 2014-01-16 23:02:11 UTC
Change 106249 merged by jenkins-bot:
Immediately trigger new scroll event after adding infinite scoll content

https://gerrit.wikimedia.org/r/106249
Comment 5 Quiddity 2014-05-02 19:07:41 UTC
Bumping to increase priority.

Previously (months ago), it would load more topics if I rolled the mouse-scrollwheel. 
Currently, it's not even doing that - at least at this page, which is short enough (whilst only showing one topic) to fit on my screen without any vertical scrollbar. https://www.mediawiki.org/wiki/Talk:Beta_Features/Hovercards
Comment 6 Quiddity 2014-05-27 21:25:38 UTC
Created attachment 15491 [details]
screenshot

Confirming as still an issue, when the number of visible topics puts the "Older topics" link above the fold (ie. there's no vertical scrollbar), which might be because the topics are in "small view" collapsed mode, or because there just aren't many (undeleted) topics in the first ten.
Comment 7 spage 2014-05-29 22:50:38 UTC
*** Bug 65897 has been marked as a duplicate of this bug. ***
Comment 8 spage 2014-05-29 23:00:30 UTC
Gerrit change #106249 triggers a new scroll in JavaScript, but it doesn't seem to work on the initial page load, and it isn't as good as sending 10 visible topics at a time.  Also, even for logged-in and admins who can see hidden (and deleted, and suppressed) topics, Flow should likewise try to load 10 "real" topics" in addition to possibly dozens of these hidden (deleted, suppressed) topics.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links