Last modified: 2013-12-27 18:28:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T60987, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 58987 - Profiling errors in CirrusSearchSearcher


Summary:	Profiling errors in CirrusSearchSearcher

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CirrusSearch (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nik Everett

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-12-27 06:29 UTC by Ori Livneh
Modified:	2013-12-27 18:28 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ori Livneh 2013-12-27 06:29:03 UTC

I noticed these while hacking on the profiler:

<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::fixupQueryStringPart), out(CirrusSearchSearcher::searchText-escape)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-build-query), out(CirrusSearchSearcher::fixupWholeQueryString)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-escape), out(CirrusSearchSearcher::searchText-build-query)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain), out(CirrusSearchSearcher::searchText-find-phrase-queries)]]></eventname>
<eventname><![CDATA[test2:-:Profiling error: in(CirrusSearchSearcher::searchText-switch-prefix-to-plain), out(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain)]]></eventname>

Comment 1 Nik Everett 2013-12-27 14:55:11 UTC

I'll fix it now.

Comment 2 Nik Everett 2013-12-27 15:04:28 UTC

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::fixupQueryStringPart),
out(CirrusSearchSearcher::searchText-escape)]]></eventname>

Found it.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-build-query),
out(CirrusSearchSearcher::fixupWholeQueryString)]]></eventname>

Found it.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-escape),
out(CirrusSearchSearcher::searchText-build-query)]]></eventname>

Couldn't find an error.  I believe this is caused by the top two errors.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain),
out(CirrusSearchSearcher::searchText-find-phrase-queries)]]></eventname>

Found it.

<eventname><![CDATA[test2:-:Profiling error:
in(CirrusSearchSearcher::searchText-switch-prefix-to-plain),
out(CirrusSearchSearcher::searchText-switch-phrase-queries-to-plain)]]></eventname>

Found it.

Comment 3 Gerrit Notification Bot 2013-12-27 15:05:36 UTC

Change 104031 had a related patch set uploaded by Manybubbles:
Fix profiling method calls

https://gerrit.wikimedia.org/r/104031

Comment 4 Gerrit Notification Bot 2013-12-27 16:36:58 UTC

Change 104031 merged by jenkins-bot:
Fix profiling method calls

https://gerrit.wikimedia.org/r/104031

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links