Last modified: 2014-01-16 19:20:32 UTC
Created attachment 14179 [details] Screenshot of the error Steps to reproduce: 1.Open the editor for page 2.Go to Insert>Template 3.Search for template Cite Web 4.Add a a value for source title field but keep the URL field empty 5.Add the template 6.Click the button "Save Page" Observed Result: The "Save Page" button does not work .In the console it is showing an error: Uncaught TypeError: Object [object Text] has no method 'setAttribute' See the screenshot attached
Test Environment: http://en.wikipedia.beta.wmflabs.org/ Browser: Chrome Version 26.0.1410.65 OS: MAC OS X 10. 8. 5 Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=27th_december&veaction=edit
I can reproduce this problem as well. A pity, because not being able to save makes the Visual Editor, well, pretty much useless. I've changed priority to 'High' for that reason.
Adding to my previous comment: when i try to switch to wiki markup mode i get the same error. No way to save my stuff :( Here's a stack trace: Uncaught TypeError: Object [object Text] has no method 'setAttribute' ve.dm.MWTransclusionNode.static.toDomElements ve.dm.Converter.getDomElementsFromDataElement ve.dm.Converter.getDomSubtreeFromData ve.dm.MWReferenceNode.static.toDomElements ve.dm.Converter.getDomElementsFromDataElement ve.dm.Converter.getDomSubtreeFromData ve.dm.Converter.getDomSubtreeFromModel ve.dm.Converter.getDomFromModel ve.init.mw.ViewPageTarget.editSource ve.ui.MWEditModeSourceTool.onSelect OO.ui.ToolGroup.onMouseUp OO.ui.PopupToolGroup.onMouseUp proxy jQuery.event.dispatch elemData.handle.eventHandle
This s\is happening for adding all templates on test2.
*This is happening for adding all templates on test2*
Change 107511 had a related patch set uploaded by Esanders: Wrap text nodes in spans if trying to mark as data-ve-ignore https://gerrit.wikimedia.org/r/107511
Change 107530 had a related patch set uploaded by Catrope: Wrap text nodes in spans if trying to mark as data-ve-ignore https://gerrit.wikimedia.org/r/107530
Change 107531 had a related patch set uploaded by Catrope: Wrap text nodes in spans if trying to mark as data-ve-ignore https://gerrit.wikimedia.org/r/107531
Change 107511 merged by jenkins-bot: Wrap text nodes in spans if trying to mark as data-ve-ignore https://gerrit.wikimedia.org/r/107511
Fix has been merged, backported and will be deployed during tomorrow's lightning deploy window (Thu Jan 16 00:00 - 00:30 UTC; Wed Jan 15 16:00 - 16:30 PST)
data-ve-ignore showing up in converter in some cases still. Working on a fix.
Change 107559 had a related patch set uploaded by Esanders: About-group extra DOM data in toDomElements https://gerrit.wikimedia.org/r/107559
Change 107559 merged by jenkins-bot: About-group extra DOM data in toDomElements https://gerrit.wikimedia.org/r/107559
Change 107638 had a related patch set uploaded by Catrope: About-group extra DOM data in toDomElements https://gerrit.wikimedia.org/r/107638
Change 107640 had a related patch set uploaded by Catrope: About-group extra DOM data in toDomElements https://gerrit.wikimedia.org/r/107640
Change 107531 merged by Catrope: Wrap text nodes in spans if trying to mark as data-ve-ignore https://gerrit.wikimedia.org/r/107531
Change 107640 merged by Catrope: About-group extra DOM data in toDomElements https://gerrit.wikimedia.org/r/107640
Change 107530 merged by Catrope: Wrap text nodes in spans if trying to mark as data-ve-ignore https://gerrit.wikimedia.org/r/107530
Change 107638 merged by Catrope: About-group extra DOM data in toDomElements https://gerrit.wikimedia.org/r/107638
Now fixed and back-ported to production.
This issue is verified for test2.But in mw.org I still cannot save after adding a template in Chrome 26.0.1410.65, however it does not show any error in the console as such Uncaught TypeError: Object [object Text] has no method 'setAttribute' In FireFox, it works for both test 2 and mw.org. Hence reopening it.If it is a separate issue please Close this one , I will file a separate issue for mw.org
Can't reproduce on mw.org. Which template did you use?
(In reply to comment #21) > This issue is verified for test2.But in mw.org I still cannot save after > adding > a template in Chrome 26.0.1410.65, however it does not show any error in the > console as such Uncaught TypeError: Object [object Text] has no method > 'setAttribute' > > In FireFox, it works for both test 2 and mw.org. > > Hence reopening it.If it is a separate issue please Close this one , I will > file a separate issue for mw.org Maybe if you refresh it will go away? Sounds most likely like a cacheing issue…
Works for mw.org in Chrome now.Might be a caching issue.
