Last modified: 2014-02-12 23:53:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61009, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59009 - beta labs: upload image fails
beta labs: upload image fails
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
: browser-test-bug
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-27 22:10 UTC by Chris McMahon
Modified: 2014-02-12 23:53 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
broken thumbs on images displayed after page refresh (30.60 KB, image/png)
2013-12-27 22:10 UTC, Chris McMahon
Details

Description Chris McMahon 2013-12-27 22:10:31 UTC
Created attachment 14180 [details]
broken thumbs on images displayed after page refresh

Seen in Firefox on beta labs 27 Dec

as a logged in user at http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Uploads

upload an image
fill in description, click Submit
get 'Uploading image' dialog and spinner

* Spinner stops with no error.  Page should display new image with description, but does not.

* Refresh page. Uploaded images may or may not display a broken thumbnail.  The broken thumbs shown in the attachment were created manually via Chrome.
Comment 1 Bingle 2013-12-27 22:20:29 UTC
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1587
Comment 2 Jon 2013-12-30 19:59:07 UTC
This sounds like it's due to the 500 errors on beta labs?
Comment 3 Chris McMahon 2013-12-30 20:05:47 UTC
I don't think it was 503s, but it may have been some other local condition at the time. 

FWIW, I think we have all but eliminated the 503 errors on beta at this point.
Comment 4 Jon 2013-12-31 23:02:58 UTC
http://commons.wikimedia.beta.wmflabs.org/w/api.php?useformat=mobile&r=0.49145484203472733&origin=http://en.m.wikipedia.beta.wmflabs.org is returning with a token error

{"servedby":"deployment-apache33","error":{"code":"badtoken","info":"Invalid token"}}

Not sure why..
Comment 5 Chris McMahon 2014-01-02 21:41:14 UTC
I'm still not seeing files uploaded via the Mobile interface on beta labs.  

I can see the POST for the Mobile upload in api.log but I have not found any errors associated with it in any logs.  

Regular UploadWizard continues to work properly. 

Last successful upload was Dec 30
Comment 6 Jon 2014-01-02 22:59:40 UTC
I3e927ec9b9d171cc227da25be43643e6ce21a308 < This might have introduced it. Do we know exactly when the problem occurred?
Comment 7 Jon 2014-01-02 22:59:57 UTC
(merged Mon Dec 30 22:27:18 2013 +0000)
Comment 8 Jon 2014-01-02 23:05:48 UTC
Max helped me confirm that reverting this patch fixes the problem.
Comment 9 Gerrit Notification Bot 2014-01-02 23:08:51 UTC
Change 105108 had a related patch set uploaded by Jdlrobson:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105108
Comment 10 Gerrit Notification Bot 2014-01-02 23:10:08 UTC
Change 105108 merged by jenkins-bot:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105108
Comment 11 Gerrit Notification Bot 2014-01-02 23:36:00 UTC
Change 105112 had a related patch set uploaded by MaxSem:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105112
Comment 12 Gerrit Notification Bot 2014-01-02 23:36:16 UTC
Change 105112 merged by MaxSem:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/105112
Comment 13 Gerrit Notification Bot 2014-01-13 23:24:56 UTC
Change 107264 had a related patch set uploaded by Kaldari:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/107264
Comment 14 Jon 2014-01-13 23:28:15 UTC
This is being cherry picked to enwiki - somehow the fix didn't make it there.
Comment 15 Gerrit Notification Bot 2014-01-14 00:02:19 UTC
Change 107264 merged by Kaldari:
Revert "Add short-curcuit in api.getTokens for tokens availble in user.tokens"

https://gerrit.wikimedia.org/r/107264

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links