Last modified: 2013-12-28 13:31:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61046, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59046 - REPORTS-27 URL decoding is incorrect
REPORTS-27 URL decoding is incorrect
Status: RESOLVED FIXED
Product: Tool Labs tools
Classification: Unclassified
tsreports (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Bugzilla Bug Importer (valhallasw)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-28 13:30 UTC by Bugzilla Bug Importer (valhallasw)
Modified: 2013-12-28 13:31 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bugzilla Bug Importer (valhallasw) 2013-12-28 13:30:56 UTC
This issue was converted from https://jira.toolserver.org/browse/REPORTS-27.
Summary: URL decoding is incorrect
Issue type: Bug - A problem which impairs or prevents the functions of the product.
Priority: Major
Status: Resolved
Assignee: River Tarnell <river.tarnell@wikimedia.de>

-------------------------------------------------------------------------------
From: River Tarnell <river.tarnell@wikimedia.de>
Date: Wed, 17 Sep 2008 15:51:23
-------------------------------------------------------------------------------

The query string decoder in RequestContext neglects to decode %nn escapes in URLs, meaning non-ASCII variables get incorrect values.
Comment 1 Bugzilla Bug Importer (valhallasw) 2013-12-28 13:30:58 UTC
-------------------------------------------------------------------------------
From: River Tarnell <river.tarnell@wikimedia.de>
Date: Wed, 17 Sep 2008 15:55:09
-------------------------------------------------------------------------------

Resolved in r43 by using urllib.unquote to decode the URL. This yields Latin-1 rather than a Unicode string, but since we don't actually do anything with the value other than passing it to MySQL (which also thinks it's Latin-1), it works okay.
Comment 2 Bugzilla Bug Importer (valhallasw) 2013-12-28 13:31:00 UTC
This bug was imported as RESOLVED. The original assignee has therefore not been
set, and the original reporters/responders have not been added as CC, to
prevent bugspam.

If you re-open this bug, please consider adding these people to the CC list:
Original assignee: river@TCX.ORG.UK
CC list: river@TCX.ORG.UK

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links