Last modified: 2014-01-03 02:30:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61123, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59123 - CirrusSearch: CirrusSearchLinksUpdateJob should contain titles by text rather than title objects
CirrusSearch: CirrusSearchLinksUpdateJob should contain titles by text rather...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CirrusSearch (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nik Everett
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-30 16:17 UTC by Nik Everett
Modified: 2014-01-03 02:30 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nik Everett 2013-12-30 16:17:44 UTC
CirrusSearchLinksUpdateJob should contain titles by text rather than title objects.  That should save a bit of space in serialized titles.
Comment 1 Nik Everett 2013-12-30 16:18:12 UTC
When doing this, we'll have to make sure to stay backwards compatible with arrays of tiles on the queue.
Comment 2 Nik Everett 2013-12-30 16:20:30 UTC
I'm seeing us running out of memory trying to push jobs on rare occasions:

#0 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueRedis.php(810): serialize(Array)
#1 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueRedis.php(250): JobQueueRedis->serialize(Array)
#2 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueRedis.php(216): JobQueueRedis->pushBlobs(Object(RedisConnRef), Array)
#3 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueFederated.php(289): JobQueueRedis->doBatchPush(Array, 1)
#4 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueFederated.php(220): JobQueueFederated->tryJobInsertions(Array, Object(HashRing), 0)
#5 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueue.php(340): JobQueueFederated->doBatchPush(Array, 0)
#6 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueue.php(311): JobQueue->batchPush(Array, 0)
#7 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueGroup.php(129): JobQueue->push(Array)
#8 /usr/local/apache/common-local/php-1.23wmf7/extensions/CirrusSearch/includes/CirrusSearchHooks.php(159): JobQueueGroup->push(Object(CirrusSearchLinksUpdateJob))
#9 [internal function]: CirrusSearchHooks::linksUpdateCompletedHook(Object(LinksUpdate))

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links