Last modified: 2014-01-07 08:05:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61175, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59175 - Clicking on a region scrolls whole page instead of just relevant box
Clicking on a region scrolls whole page instead of just relevant box
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UniversalLanguageSelector (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Amir E. Aharoni
https://translatewiki.net/wiki/Suppor...
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-12-31 23:53 UTC by Yair Rand
Modified: 2014-01-07 08:05 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---
siebrand: Backport_WMF+


Attachments

Description Yair Rand 2013-12-31 23:53:19 UTC
In ULS's "Select language" box (accessed by clicking the "English" button next to one's username on wikis such as Wikidata), clicking on one of the regions ("America", "Asia/Pacific", etc, in the map) causes the entire page to scroll down so that the top of the page is at the top of the relevant header, pushing the rest of the Select language box (including the search box and map), and much of the background page, off screen. 

A preferable behavior, I think, would be to just have the box containing the languages (.uls-language-list) scroll down to the header, without moving the surrounding page.
Comment 1 Niklas Laxström 2014-01-02 11:13:42 UTC
What browser are you using?
Comment 2 Siebrand Mazeland 2014-01-05 18:23:08 UTC
I can reproduce this on OSX 10.9.1 with Firefox 26.0 and Google Crome 31.0.1650.63.


Steps to reproduce:
1. Go to URL (this must be a page that is taller than the browser window, i.e. has a vertical scroll bar)
2. Open ULS
3. Click "Europe" on the map (3rd area of 4).

Observed:
I. Page scrolls to Europe
II. Language list scroll to Europe

Expected:
II. Page stays at the same level horizontal level
III. Language list scrolls to Europe
Comment 3 Siebrand Mazeland 2014-01-06 07:32:59 UTC
This issue is tracked in mingle as https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/3940
Comment 4 Amir E. Aharoni 2014-01-06 09:47:08 UTC
Upstream patch: https://github.com/wikimedia/jquery.uls/pull/123
Comment 5 Gerrit Notification Bot 2014-01-06 11:34:15 UTC
Change 105663 had a related patch set uploaded by Amire80:
When clicking a region, scroll only the list and not the whole page

https://gerrit.wikimedia.org/r/105663
Comment 6 Gerrit Notification Bot 2014-01-06 12:26:04 UTC
Change 105663 merged by jenkins-bot:
When clicking a region, scroll only the list and not the whole page

https://gerrit.wikimedia.org/r/105663
Comment 7 Gerrit Notification Bot 2014-01-06 12:29:53 UTC
Change 105671 had a related patch set uploaded by Siebrand:
When clicking a region, scroll only the list and not the whole page

https://gerrit.wikimedia.org/r/105671
Comment 8 Gerrit Notification Bot 2014-01-07 08:05:08 UTC
Change 105671 merged by jenkins-bot:
When clicking a region, scroll only the list and not the whole page

https://gerrit.wikimedia.org/r/105671

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links