Last modified: 2014-10-19 17:44:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61176, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59176 - use browser_label from env.rb instead of BROWSER_LABEL env var in Flow tests
use browser_label from env.rb instead of BROWSER_LABEL env var in Flow tests
Status: NEW
Product: Wikimedia
Classification: Unclassified
Quality Assurance (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Chris McMahon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-01 00:34 UTC by Chris McMahon
Modified: 2014-10-19 17:44 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2014-01-01 00:34:51 UTC
Reverted https://gerrit.wikimedia.org/r/#/c/104783/ because it requires that the BROWSER_LABEL environment variable be set, and this is not always true.  

Instead, we should use the local definition of browser_label from support/env.rb:

def local_browser(user_agent)
  if ENV['BROWSER_LABEL']
    browser_label = ENV['BROWSER_LABEL'].to_sym
  else
    browser_label = :firefox
  end

This requires making the browser_label variable available beyond the scope of of the local method.
Comment 1 Željko Filipin 2014-02-14 11:40:32 UTC
See also bug 61067.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links