Last modified: 2014-01-02 16:35:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61186, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59186 - Update GeSHi to 1.0.8.12.
Update GeSHi to 1.0.8.12.
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-01 16:42 UTC by Edward Hart
Modified: 2014-01-02 16:35 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Edward Hart 2014-01-01 16:42:43 UTC
GeSHi 1.0.8.12 is a minor update which adds support for more languages and has bug fixes for already existing languages.
Comment 1 Sam Reed (reedy) 2014-01-01 18:49:58 UTC
(In reply to comment #0)
> GeSHi 1.0.8.12 is a minor update which adds support for more languages and
> has
> bug fixes for already existing languages.

This isn't a release yet... And looking in trunk, it's still versioned at '1.0.8.11'
Comment 2 Andre Klapper 2014-01-01 20:07:53 UTC
No such download listed on http://sourceforge.net/projects/geshi/files/geshi/ hence nothing that can (currently) be done here. Request is welcome once such a tarball exists.
Comment 3 Edward Hart 2014-01-02 09:36:45 UTC
(In reply to comment #2)
> No such download listed on http://sourceforge.net/projects/geshi/files/geshi/
> hence nothing that can (currently) be done here. Request is welcome once
> such a
> tarball exists.

BenBE migrated GeSHi to GitHub in November which is were you can find 1.0.8.12. (https://github.com/GeSHi/geshi-1.0)
Comment 4 Andre Klapper 2014-01-02 12:49:18 UTC
Ah thanks! http://qbnz.com/highlighter/news.php?id=132 covers that.
But http://qbnz.com/highlighter/ still says "The latest stable version of GeSHi is 1.0.8.11" and "Downloads" links to http://sourceforge.net/projects/geshi/files/ . So what is the URL for a 1.0.8.12 tarball?
Comment 5 Derk-Jan Hartman 2014-01-02 12:56:25 UTC
There also isn't a tag yet it seems: https://github.com/GeSHi/geshi-1.0/releases
Comment 6 Edward Hart 2014-01-02 14:09:21 UTC
> what is the URL for a 1.0.8.12 tarball?
There doesn't appear to be one. I'm sorry, I assumed there was when I reported this bug. You can download the repo as a .zip (https://github.com/GeSHi/geshi-1.0/archive/master.zip) but it may be better for BenBE to properly tag it as a release.
Comment 7 Sam Reed (reedy) 2014-01-02 15:10:05 UTC
A tarball isn't necessary, but a tag is pretty useful.

Chances are the version was bumped in master and development continued so people weren't reporting bugs in 1.0.8.11 that were there.

If there's a specific bugfix we could bring in the HEAD of master, and change the version to '1.0.8.12-cf5f2b' or similar. We have made minor modifications to the version currently in our repos to bring bugfixes.

Although we could track master as a git submodule, this becomes painful for WMF usage, as we'll need to have a copy of the repo in out care to use as a submodule, which then requires manual syncing/tracking of upstream.



Having said all that https://github.com/GeSHi/geshi-1.0/blame/master/src/geshi.php#L44 is still 1.0.8.11. So there isn't anything to do for this
Comment 8 Edward Hart 2014-01-02 16:35:51 UTC
OK, then. Thanks for looking into this anyway.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links