Last modified: 2014-01-13 18:26:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61237, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 59237 - "PHP Notice"s from Special:RecentChanges from RecentChanges/Formatter.php


Summary:	"PHP Notice"s from Special:RecentChanges from RecentChanges/Formatter.php

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Flow (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://ee-flow.wmflabs.org/wiki/Speci...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-01-03 02:38 UTC by spage
Modified:	2014-01-13 18:26 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-01-03 02:38:02 UTC

Visiting ee-flow's Special:RecentChanges seems to work, but generates a dozen or so notices in apache2/error.log, all like:

[Fri Jan 03 02:20:38 2014] [error] [client 216.38.130.164] PHP Notice:  Undefined variable: row in /srv/mediawiki/extensions/Flow/includes/RecentChanges/Formatter.php on line 87
[Fri Jan 03 02:20:38 2014] [error] [client 216.38.130.164] PHP Notice:  Trying to get property of non-object in /srv/mediawiki/extensions/Flow/includes/RecentChanges/Formatter.php on line 87
...

The same notices appear on-screen in my local wiki

Line 87 is
  . $this->getActionDescription( $workflow, $row->blocktype, $revision, $user );

There's no $row variable in the file, but anything's possible with PHP trickery :)

Comment 1 Bingle 2014-01-03 02:42:33 UTC

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/678, but people from the community are welcome to contribute here and in Gerrit.

Comment 2 Gerrit Notification Bot 2014-01-03 19:48:23 UTC

Change 105245 had a related patch set uploaded by EBernhardson:
Fix undefined variable in recentchanges formatter

https://gerrit.wikimedia.org/r/105245

Comment 3 Gerrit Notification Bot 2014-01-04 00:21:25 UTC

Change 105245 merged by jenkins-bot:
Fix undefined variable in recentchanges formatter

https://gerrit.wikimedia.org/r/105245

Comment 4 Kunal Mehta (Legoktm) 2014-01-11 06:12:06 UTC

Patch was merged, is this fixed now?

Comment 5 spage 2014-01-13 18:26:10 UTC

Let's assume so!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links