Last modified: 2014-01-04 13:53:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61393, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59393 - DRTRIGON-131 Reduce bot_control.py influence, try to unlink features
DRTRIGON-131 Reduce bot_control.py influence, try to unlink features
Status: RESOLVED FIXED
Product: Tool Labs tools
Classification: Unclassified
DrTrigonBot - General (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: DrTrigon
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-03 16:01 UTC by Bugzilla Bug Importer (valhallasw)
Modified: 2014-01-04 13:53 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bugzilla Bug Importer (valhallasw) 2014-01-03 16:01:41 UTC
This issue was converted from https://jira.toolserver.org/browse/DRTRIGON-131.
Summary: Reduce bot_control.py influence, try to unlink features
Issue type: Improvement - An improvement or enhancement to an existing feature or task.
Priority: Major
Status: Closed
Assignee: drtrigon <dr.trigon@surfeu.ch>

-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Wed, 02 Jan 2013 21:46:37
-------------------------------------------------------------------------------

Try to simplify functions and to unlink/move them from `bot_control.py` and put into framework upstream or bot scripts.

  * make the magicwords mechanism independent from `bot_control.py` by using `subster_irc.py` (which runs all the time) and connect to it by IRC channel (private communication) or alternatively by XML-RCP 
    * use a local file (e.g. `cache/state_bots`) and allow `subster.py` the access to it (like url, mail or any other source)
    * use same (simple) IRC code as in `subster_irc.py` or (very simple) in `panel.py`
    * http://docs.python.org/2/library/xmlrpclib.html
    * http://docs.python.org/2/library/simplexmlrpcserver.html
  * error handler (with mail) 
    * let the logging module do this, with help of class `AdminEmailHandler`
  * logger 
    * e.g. move logging/logger stuff to `wikipedia.py` function `log(...)` (use '-log') and emulate 'info', 'warning', ... by using messages/text like "INFO: ...", "WARNING: ..." (as already done), ...
  * generic info and version output
  * several patches and work-a-rounds for other buggy code (e.g. py2.6)

The first point would also remove the need to run `sum_disc.py`, `subster.py` and others in sequence (one of the main reasons for `bot_control.py`) and allow to run them all in parallel (also because of new log file regime) and thus give more freedom for cron-job setup.
Comment 1 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:01:42 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Thu, 10 Jan 2013 16:51:09
-------------------------------------------------------------------------------

magicwords mechanism replaced with a new (better) one in r459 and r460 (upstream r10878).
Comment 2 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:01:44 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Thu, 10 Jan 2013 21:55:59
-------------------------------------------------------------------------------

version output (not generic info) partly introduced in trunk `version.py` but needs more work.

in rewrite `version.py` is a script thus a new module `version.py` (in `pywikibot` directory) has to be created and the important functions have to be moved from script to module. nothing done here.

edit: trunk and rewrite are both done now!
Comment 3 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:01:45 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Tue, 15 Jan 2013 18:50:47
-------------------------------------------------------------------------------

Logging needs a format change in `wikipedia.py` in order to finally have the same log output format as **rewrite**. This change was already prepared but is still commented (out), confer r10931 (line 8750-8751).

Attention: this needs also a change in `panel.py` (that breaks compatibility) therefore archive and remove of ALL logs on server (TS) and then start with the new format.
Comment 4 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:01:47 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Mon, 21 Jan 2013 17:24:49
-------------------------------------------------------------------------------

Please have also a look at http://de.wikipedia.org/wiki/Benutzer:DrTrigonBot/Status and the comment:

> make the daily subster run independend of sum_disc in order to have good update here!
Comment 5 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:01:49 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sun, 22 Sep 2013 10:32:31
-------------------------------------------------------------------------------

Done.

Consider change from `bot_control.py` to pwb.py (compatibility with rewrite/core) as well as current crontab.
Comment 6 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:01:50 UTC
This bug was imported as RESOLVED. The original assignee has therefore not been
set, and the original reporters/responders have not been added as CC, to
prevent bugspam.

If you re-open this bug, please consider adding these people to the CC list:
Original assignee: dr.trigon@surfeu.ch
CC list: dr.trigon@surfeu.ch

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links