Last modified: 2014-01-03 16:26:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61529, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59529 - DRTRIGON-84 'botlist' and 'wikipedia' upstream need some bug fixes
DRTRIGON-84 'botlist' and 'wikipedia' upstream need some bug fixes
Status: RESOLVED FIXED
Product: Tool Labs tools
Classification: Unclassified
DrTrigonBot - General (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Bugzilla Bug Importer (valhallasw)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-03 16:26 UTC by Bugzilla Bug Importer (valhallasw)
Modified: 2014-01-03 16:26 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:14 UTC
This issue was converted from https://jira.toolserver.org/browse/DRTRIGON-84.
Summary: 'botlist' and 'wikipedia' upstream need some bug fixes
Issue type: Bug - A problem which impairs or prevents the functions of the product.
Priority: Major
Status: Resolved
Assignee: drtrigon <dr.trigon@surfeu.ch>

-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 08:37:33
-------------------------------------------------------------------------------

  * 'botlist' crashes after mediawiki update of german wiki to 1.17wmf1 a patch was provided (**but** should be version dependent also)
  * 'wikipedia' has several methods in Page object to retrieve the mediawiki software number (e.g. 'version', 'live_version', ...) but the 'live_version' in the current revision **has** always to fall back to 'version' and the internally hard coded version string, which is not that useful

both patches were sent upstream to Xqt, for verification and commit.
Comment 1 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:15 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 08:40:05
-------------------------------------------------------------------------------

patches (without version check)
Comment 2 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:17 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 08:44:54
-------------------------------------------------------------------------------

A strange or interesting fact is the member function 'headerDone' (from class '_GetAll') is able to retrieve the 'live_version' also. It uses the other way; instead of using 'Special:Version' it processes the tags given in all (newer?) mediawiki page headers, like e.g.:

`<meta name="generator" content="MediaWiki 1.17wmf1" />`

to get the actual version. May be we should just use one single method in one single place to solve this...?!?
Comment 3 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:19 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 08:46:54
-------------------------------------------------------------------------------

(add one item)
Comment 4 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:20 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 12:53:12
-------------------------------------------------------------------------------

  * 'wikipedia' done in r8984
  * 'botlist' done in r8985

I have a follow-up for both of them, but it is not important for the bot to work.
Comment 5 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:22 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 13:36:13
-------------------------------------------------------------------------------

Follow-up patches proposed to Xqt. Not done yet, but not that important anyway.
Comment 6 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:23 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 13:36:57
-------------------------------------------------------------------------------

Followups not done yet, since not that important...
Comment 7 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:25 UTC
-------------------------------------------------------------------------------
From: drtrigon <dr.trigon@surfeu.ch>
Date: Sat, 19 Feb 2011 13:38:30
-------------------------------------------------------------------------------

http://svn.wikimedia.org/svnroot/pywikipedia/branches/rewrite/pywikibot/site.py

('live_version' in re-write uses generator meta tag already)
Comment 8 Bugzilla Bug Importer (valhallasw) 2014-01-03 16:26:26 UTC
This bug was imported as RESOLVED. The original assignee has therefore not been
set, and the original reporters/responders have not been added as CC, to
prevent bugspam.

If you re-open this bug, please consider adding these people to the CC list:
Original assignee: dr.trigon@surfeu.ch
CC list: dr.trigon@surfeu.ch

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links