Last modified: 2014-04-19 03:59:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61608, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59608 - VisualEditor: [Regression] On FlaggedRevs wikis: Checkbox "Accept this version (includes n pending changes)" in save dialog is missing
VisualEditor: [Regression] On FlaggedRevs wikis: Checkbox "Accept this versio...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-04-24
Assigned To: Alex Monk
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-03 20:22 UTC by Raimond Spekking
Modified: 2014-04-19 03:59 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2014-01-03 20:22:18 UTC 
On FlaggedRevs wikis: Checkbox "Accept this version (includes n pending changes)" in save dialog is missing
Comment 1 James Forrester 2014-03-06 00:01:48 UTC 
The message is <revreview-check-flag-p>. Presumably this doesn't get fetched in the new save dialog like it used to?
Comment 2 Alex Monk 2014-03-06 01:17:48 UTC 
I see the same thing on Wikimedia sites, but cannot replicate the issue locally.
Comment 3 Alex Monk 2014-04-18 19:23:01 UTC 
In FlaggablePageView::addReviewCheck, $this->article->isReviewable() returns false.

I made some uncommitted live hacks on deployment-apache01.eqiad.wmflabs and replayed the API request in Chrome until I got the right server. Turns out, $this->article represents the "API" title. Why is this not happening on my machine?
Comment 4 Gerrit Notification Bot 2014-04-19 02:10:23 UTC 
Change 127388 had a related patch set uploaded by Alex Monk:
Set context title when rendering edit notices and checkboxes

https://gerrit.wikimedia.org/r/127388
Comment 5 Gerrit Notification Bot 2014-04-19 03:48:56 UTC 
Change 127388 merged by jenkins-bot:
Set context title when rendering edit notices and checkboxes

https://gerrit.wikimedia.org/r/127388
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links