Last modified: 2014-01-05 20:11:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61609, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59609 - Over-reliance on timestamps can lead to incorrect counts
Over-reliance on timestamps can lead to incorrect counts
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 59694
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-03 20:31 UTC by Jackmcbarn
Modified: 2014-01-05 20:11 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jackmcbarn 2014-01-03 20:31:01 UTC 
In several places in the codebase, timestamps are used to determine the order of edits and other actions, which can lead to issues in situations where several actions happen at nearly the same time. One example of this is countRevisionsBetween in title.php. If multiple revisions of a page are made within 2 seconds, it will return an incorrect count when used on those revisions. Shouldn't this and all similar uses be changed to compare based on the table's primary key instead (revision ID in this case)?
Comment 1 Umherirrender 2014-01-03 20:42:18 UTC 
Maybe related: bug 2930 / bug 17591
Comment 2 Andre Klapper 2014-01-05 03:12:37 UTC 
(In reply to comment #0)
> In several places in the codebase

Thanks for reporting this. If you are aware of more places, please list them.
Comment 3 Jackmcbarn 2014-01-05 20:02:16 UTC 
I've just now noticed that edit conflict detection in EditPage.php does the same thing.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links