Last modified: 2014-01-04 00:24:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61612, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59612 - CSRF protection for scholarship app
CSRF protection for scholarship app
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Wikimania Scholarships (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-03 21:28 UTC by Chris Steipp
Modified: 2014-01-04 00:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
CSRF middleware patch (7.55 KB, patch)
2014-01-03 23:43 UTC, Bryan Davis
Details

Description Chris Steipp 2014-01-03 21:28:31 UTC
Sorry for the late notice of this, but when I reviewed the Scholarship app originally, I missed reporting my note that it didn't have any csrf protection on its forms.

Needs to be added to public application, login form, and the admin forms that update the application's data.

Probably doesn't prevent turning on the site next week, but should get fixed soon.
Comment 1 Bryan Davis 2014-01-03 23:43:29 UTC
Created attachment 14224 [details]
CSRF middleware patch

I whipped up a quick and dirty CSRF middleware. It could be fancier (no token rotation or expiration) but it is a lot better than nothing. I'm a little embarrassed that I didn't think of the need for this before. And I'm more than a little disappointed that the Slim framework doesn't come with a solution for this out of the box.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links