Last modified: 2014-01-29 22:12:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61629, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59629 - Flow: pencil icon appears on moderated topic, and in wrong location
Flow: pencil icon appears on moderated topic, and in wrong location
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-04 00:47 UTC by spage
Modified: 2014-01-29 22:12 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-04 00:47:23 UTC
To reproduce:
* Hide a topic.

Result:
The "mini-pencil" icon appears before "This topic was hidden by Xxx". 

There are three related bugs here:
1. The real title is hidden. so the pencil icon appears on the left of the moderation action, which looks weird.
2. If the topic is hidden there's no reason to show the mini-pencil icon for its edited state.
3. If the only action on the topic is moderation, it's misleading to show the mini-pencil for it.


If we fix 2, 1 goes away.  3 comes back if you later restore the topic: you see the topic title with a mini-pencil icon, but hovering over the mini-pencil does nothing because there isn't really an edit history for the topic, just past revisions due to moderation state changes. That should be a separate bug.
Comment 1 Bingle 2014-01-04 00:54:23 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/682, but people from the community are welcome to contribute here and in Gerrit.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links