Last modified: 2014-04-04 21:41:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61637, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59637 - Flow: initial edit of header on empty Flow board page gets isAllowed Fatal
Flow: initial edit of header on empty Flow board page gets isAllowed Fatal
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-04 05:21 UTC by spage
Modified: 2014-04-04 21:41 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-04 05:21:04 UTC
Find a non-existent Flow board e.g. a user talk page on ee-flow.  Click the pencil to edit the header, then click [Save header]

You get a pink "An error occurred while contacting the server." errorbox.  On ee-flow, the apache error.log contains:

  [Sat Jan 04 04:48:56 2014] [error] [client 216.38.130.164] PHP Fatal error:  Call to a member function isAllowed() on a non-object in /srv/mediawiki/extensions/Flow/includes/Block/Header.php on line 83, referer: http://ee-flow.wmflabs.org/w/index.php?title=User_talk:4pq1injbak&action=edit

Just before this, I think upon visiting the page, there's a warning in apache error.log:

  [Sat Jan 04 04:58:07 2014] [error] [client 216.38.130.164] PHP Warning:  header() expects parameter 3 to be long, string given in /srv/mediawiki/includes/WebResponse.php on line 38, referer: http://ee-flow.wmflabs.org/w/index.php?title=User_talk:4pq1injbak&action=edit

Note there's a separate bug 58018 about the different error you get trying to preview the header change on a non-existent page.
Comment 1 Bingle 2014-01-04 05:42:33 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/685, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2014-01-21 21:44:16 UTC
Change 108833 had a related patch set uploaded by Werdna:
Ensure that revision action permissions are initialised even for headers on new boards.

https://gerrit.wikimedia.org/r/108833
Comment 3 Gerrit Notification Bot 2014-01-21 21:49:46 UTC
Change 108833 merged by jenkins-bot:
Ensure that revision action permissions are initialised even for headers on new boards.

https://gerrit.wikimedia.org/r/108833
Comment 4 Gerrit Notification Bot 2014-01-22 01:47:07 UTC
Change 108879 had a related patch set uploaded by Werdna:
Create test for bug 59637

https://gerrit.wikimedia.org/r/108879
Comment 5 Gerrit Notification Bot 2014-04-04 21:41:48 UTC
Change 108879 merged by jenkins-bot:
Create test for bug 59637

https://gerrit.wikimedia.org/r/108879

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links