Last modified: 2014-01-31 18:31:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61642, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59642 - Flow: browser test got 'failed insert' exception adding a topic
Flow: browser test got 'failed insert' exception adding a topic
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-04 09:16 UTC by spage
Modified: 2014-01-31 18:31 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-04 09:16:35 UTC
Similar to bug 58996, a browser test failed at line 498 of includes/Data/ObjectManager.php: with failed insert.

The difference is this is adding a new topic (in $storage->put( $firstPost )), not editing an existing post.  Again there were overlapping tests hitting the same Flow QA page at the time, maybe another browser test was trying to edit this post just as the API call was returning; or could two browsers hitting the same Flow_QA page cause problems even if they're adding unrelated topics?

If you look at the Sauce Labs report (scroll down and click the camera), you can see the [Add topic] quickly resulted in a pink errorbox with "Exception Caught: failed insert".  Yet, you can find the topic in RecentChanges (search for its random string "0.6552491559"), and you can view it and its first post, seemingly no worse for wear, at https://test2.wikipedia.org/w/index.php?title=Talk:Flow_QA&workflow=050d6fd80a11168d809390b11c279739 .  So if storing the post failed, why is it there?  It was only two hours ago, am I seeing cached success hiding a DB failure?

It's unfortunate there isn't more information about what went wrong; the insert() only returns true/false, but maybe lower levels could log something.  
Here's the output in fluorine:/a/mw-log/archive/exception.log-20140104.gz , I couldn't find anything related in the compressed (huge) api.log, dberror.log, external.log, or anything at exactly that time in test2wiki.log.  Maybe DB failures on flowdb are written somewhere else, see https://wikitech.wikimedia.org/wiki/Logs

  2014-01-04 06:34:46 mw1202 test2wiki: [e4273fd5] /w/api.php   Exception from line 498 of /usr/local/apache/common-local/php-1.23wmf9/extensions/Flow/includes/Data/ObjectManager.php: failed insert
#0 /usr/local/apache/common-local/php-1.23wmf9/extensions/Flow/includes/Data/ObjectManager.php(470): Flow\Data\ObjectManager->insert(Object(Flow\Model\PostRevision))
#1 /usr/local/apache/common-local/php-1.23wmf9/extensions/Flow/includes/Data/ObjectManager.php(167): Flow\Data\ObjectManageBr->put(Object(Flow\Model\PostRevision))
#2 /usr/local/apache/common-local/php-1.23wmf9/extensions/Flow/includes/Block/TopicList.php(101): Flow\Data\ManagerGroup->put(Object(Flow\Model\PostRevision))
#3 /usr/local/apache/common-local/php-1.23wmf9/extensions/Flow/includes/WorkflowLoader.php(204): Flow\Block\TopicListBlock->commit()
#4 /usr/local/apache/common-local/php-1.23wmf9/extensions/Flow/includes/api/ApiFlow.php(59): Flow\WorkflowLoader->commit(Object(Flow\Model\Workflow), Array)
#5 /usr/local/apache/common-local/php-1.23wmf9/includes/api/ApiMain.php(862): ApiFlow->execute()
#6 /usr/local/apache/common-local/php-1.23wmf9/includes/api/ApiMain.php(387): ApiMain->executeAction()
#7 /usr/local/apache/common-local/php-1.23wmf9/includes/api/ApiMain.php(358): ApiMain->executeActionWithErrorHandling()
#8 /usr/local/apache/common-local/php-1.23wmf9/api.php(76): ApiMain->execute()
#9 /usr/local/apache/common-local/w/api.php(3): require('/usr/local/apac...')
#10 {main}
Comment 1 Bingle 2014-01-04 09:18:23 UTC
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/688, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2014-01-08 19:12:54 UTC
Change 106165 had a related patch set uploaded by EBernhardson:
Dont try and do sane things, like generalizing specific exceptions

https://gerrit.wikimedia.org/r/106165
Comment 3 Gerrit Notification Bot 2014-01-08 19:18:43 UTC
Change 106165 merged by jenkins-bot:
Dont try and do sane things, like generalizing specific exceptions

https://gerrit.wikimedia.org/r/106165
Comment 4 Gerrit Notification Bot 2014-01-08 23:17:57 UTC
Change 106449 had a related patch set uploaded by EBernhardson:
Track the root of a post tree explicitly

https://gerrit.wikimedia.org/r/106449
Comment 5 Gerrit Notification Bot 2014-01-21 16:42:48 UTC
Change 106449 merged by jenkins-bot:
Track the root of a post tree explicitly

https://gerrit.wikimedia.org/r/106449

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links