Last modified: 2014-04-07 16:59:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61663, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59663 - Installer says wrong message when DB username is not given during install
Installer says wrong message when DB username is not given during install
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.23.0
All All
: Normal normal (vote)
: ---
Assigned To: Tony Thomas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-05 05:21 UTC by Tony Thomas
Modified: 2014-04-07 16:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tony Thomas 2014-01-05 05:21:45 UTC
Originally from https://bugzilla.wikimedia.org/show_bug.cgi?id=43528#c1 :
The installer shows the error "MySQL 5.0.2 or later is required. You have " when the user supplies nothing into the DB username field.
Comment 1 Tony Thomas 2014-01-05 16:43:10 UTC
Actually I couldn't find the code that triggers the above message when the username is not given. The default value for DBusername is given as root, so a null check wont be necessary. But how the message shows up is the error!
Comment 2 MZMcBride 2014-01-06 07:03:38 UTC
Inside mediawiki-core/includes/installer:

---
$ grep -R ". You have" *

Installer.i18n.php:	'config-mysql-old'                => 'MySQL $1 or later is required. You have $2.',

Installer.i18n.php:	'config-postgres-old'             => 'PostgreSQL $1 or later is required. You have $2.',

Installer.i18n.php:	'config-mysql-myisam-dep'         => "'''Warning:''' You have selected MyISAM as storage engine for MySQL, which is not recommended for use with MediaWiki, because:
---

So you want to search for where "config-mysql-old" and other message keys are called (try looking for "config-" inside installer/Installer.php).
Comment 3 Tony Thomas 2014-01-06 12:38:19 UTC
(In reply to comment #2)
after grepping in installer/ the only place where the message config-mysql-old comes out is 
if ( version_compare( $version, $this->minimumVersion ) < 0 ) {
			return Status::newFatal( 'config-mysql-old', $this->minimumVersion, $version );
		}
but, strangely that comes out too when the username is kept null.
Comment 4 Tony Thomas 2014-03-25 13:52:40 UTC
https://gerrit.wikimedia.org/r/#/c/118798/
Comment 5 Gerrit Notification Bot 2014-03-26 04:15:09 UTC
Change 118798 had a related patch set uploaded by 01tonythomas:
Error Msg for missing db username & password  when installing

https://gerrit.wikimedia.org/r/118798
Comment 6 Gerrit Notification Bot 2014-04-07 16:59:02 UTC
Change 118798 merged by jenkins-bot:
Error Msg for missing db username & password  when installing

https://gerrit.wikimedia.org/r/118798

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links