Last modified: 2014-02-18 23:58:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61671, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59671 - Default whitespace for page property magic words should be to put them on their own line
Default whitespace for page property magic words should be to put them on the...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-05 10:55 UTC by Roan Kattouw
Modified: 2014-02-18 23:58 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-01-05 10:55:31 UTC
Page property magic words like __NOTOC__ should appear on their own line when serializing. Right now, editing a page that's already in category "Foo" and adding NOTOC as well as the category Bar produces:

[[Category:Foo]]__NOTOC__
[[Category:Bar]]

which shows that categories have the whitespace behavior we want (almost; they seem to get a preceding newline rather than being put on their own line, but that usually doesn't matter in practice) but magic words don't.
Comment 1 Roan Kattouw 2014-01-05 11:24:40 UTC
This is especially bad for #REDIRECT, which doesn't work if it's not on its own line.

[[Category:Foo]]#REDIRECT [[Bar]]

results in a category followed by plain text "#REDIRECT [[Bar]]"
Comment 2 Gerrit Notification Bot 2014-02-07 01:32:17 UTC
Change 111948 had a related patch set uploaded by GWicke:
Bug 59671: Serialize new page properties on their own line

https://gerrit.wikimedia.org/r/111948
Comment 3 Gabriel Wicke 2014-02-07 01:33:22 UTC
Test case:

echo 'foo<meta property="mw:PageProp/notoc"/>bar' | node parse --html2wt
foo
__NOTOC__
bar
Comment 4 Gerrit Notification Bot 2014-02-11 05:04:30 UTC
Change 111948 merged by jenkins-bot:
Bug 59671: Serialize new page properties on their own line

https://gerrit.wikimedia.org/r/111948
Comment 5 James Forrester 2014-02-18 19:48:38 UTC
Input:

  <p>Foo<link rel="mw:PageProp/redirect" href="./Foo"></p>

Output:

  Foo#REDIRECT [[Foo]]

Expected output:

  Foo
  #REDIRECT [[Foo]]
Comment 6 Gerrit Notification Bot 2014-02-18 22:35:10 UTC
Change 114089 had a related patch set uploaded by GWicke:
Bug 59671: Serialize new redirects on their own line

https://gerrit.wikimedia.org/r/114089
Comment 7 Gerrit Notification Bot 2014-02-18 23:58:19 UTC
Change 114089 merged by jenkins-bot:
Bug 59671: Serialize new redirects on their own line

https://gerrit.wikimedia.org/r/114089
Comment 8 Gabriel Wicke 2014-02-18 23:58:52 UTC
Scheduled for deployment tomorrow.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links