Last modified: 2014-01-28 18:22:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61672, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59672 - forcetoc meta with data-parsoid from a notoc meta gets serialized to __NOTOC__ instead of __FORCETOC__
forcetoc meta with data-parsoid from a notoc meta gets serialized to __NOTOC_...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-05 11:10 UTC by Roan Kattouw
Modified: 2014-01-28 18:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-01-05 11:10:24 UTC 
If I have a wiki page containing __NOTOC__, Parsoid outputs:

<meta property="mw:PageProp/notoc" data-parsoid='{"src":"__NOTOC__","magicSrc":"__NOTOC__","dsr":[966,975,null,null]}'>

When VE edits this and changes the property attribute from notoc to forcetoc, we end up serializing:

<meta property="mw:PageProp/forcetoc" data-parsoid='{"src":"__NOTOC__","magicSrc":"__NOTOC__","dsr":[966,975,null,null]}'>

Which should serialize to __FORCETOC__, but instead the data-parsoid wins and this serializes to __NOTOC__.
Comment 1 Gerrit Notification Bot 2014-01-28 03:38:09 UTC 
Change 109835 had a related patch set uploaded by Arlolra:
Prefer magic word from property to data-parsoid

https://gerrit.wikimedia.org/r/109835
Comment 2 Gerrit Notification Bot 2014-01-28 18:18:04 UTC 
Change 109835 merged by jenkins-bot:
Prefer magic word from property to data-parsoid

https://gerrit.wikimedia.org/r/109835
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links