Last modified: 2014-02-12 20:01:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61674, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59674 - Editing redirect hrefs is broken, causes piped link
Editing redirect hrefs is broken, causes piped link
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-05 11:51 UTC by Roan Kattouw
Modified: 2014-02-12 20:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-01-05 11:51:38 UTC
Input wikitext:

#REDIRECT [[Foo]]

Output HTML:

<link rel="mw:PageProp/redirect" href="./Foo" data-parsoid='{"src":"#REDIRECT ","a":{"href":"./Foo"},"sa":{"href":"Foo"},"dsr":[0,17,null,null]}'>

Modified HTML (href set to "Bar"):

<link rel="mw:PageProp/redirect" href="Bar" data-parsoid='{"src":"#REDIRECT ","a":{"href":"./Foo"},"sa":{"href":"Foo"},"dsr":[0,17,null,null]}'>

Output wikitext:

#REDIRECT [[Bar|Foo]]



The real WTF here is that that actually *works*, it redirects to Bar like it's supposed to.
Comment 1 ssastry 2014-02-07 00:03:21 UTC
I quickly investigated this and it looks like piped links in redirects are supported according to this parser test:

https://git.wikimedia.org/blob/mediawiki%2Fservices%2Fparsoid.git/0b5db8b91bfdeb0a304b372dd8dda123b3fd1ab6/tests%2FparserTests.txt#L5962

I also verified in the WP sandbox that PHP parser also respects it (which is what I suppose you also meant).

So, I guess the expectation is that we dont emit piped links for redirects?
Comment 2 Gerrit Notification Bot 2014-02-07 18:56:56 UTC
Change 112043 had a related patch set uploaded by Subramanya Sastry:
(Bug 59674) Emit non-piped links for edited redirect links

https://gerrit.wikimedia.org/r/112043
Comment 3 Gerrit Notification Bot 2014-02-07 20:21:46 UTC
Change 112043 merged by jenkins-bot:
(Bug 59674) Emit non-piped links for edited redirect links

https://gerrit.wikimedia.org/r/112043

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links