Last modified: 2014-02-18 13:48:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61676, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59676 - wbgetentities not working with multiple sites
wbgetentities not working with multiple sites
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Normal normal (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-05 12:52 UTC by Mushroom
Modified: 2014-02-18 13:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mushroom 2014-01-05 12:52:40 UTC
According to the API documentation, wbgetentities should accept requests with:
• one site for several titles, or
• several sites for one title.

However, patch 80797 changed the code to only allow:
• one site and several titles, or
• equal numbers of sites and titles.

(see here: https://gerrit.wikimedia.org/r/#/c/80797/)

So this request works fine:
https://www.wikidata.org/w/api.php?action=wbgetentities&sites=enwiki|itwiki&titles=London|Berlin

But this one returns an error:
https://www.wikidata.org/w/api.php?action=wbgetentities&sites=enwiki|itwiki&titles=London

It doesn't make sense, the older behavior should be restored.
Comment 1 Mushroom 2014-01-05 15:13:30 UTC
I have submitted a patch that fixes this bug: https://gerrit.wikimedia.org/r/#/c/105511/1
Comment 2 Andre Klapper 2014-01-05 15:40:53 UTC
Thanks, Mushroom! For future reference, see http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for formatting the commit message.
Comment 3 Mushroom 2014-01-05 20:29:26 UTC
Thanks Andre, it was my first commit here. Next time I'll definitely follow the guidelines!
Comment 4 Gerrit Notification Bot 2014-01-15 19:13:32 UTC
Change 105511 had a related patch set uploaded by Mushroom:
Fix ItemByTitleHelper site/title combinations

https://gerrit.wikimedia.org/r/105511
Comment 5 Gerrit Notification Bot 2014-01-26 14:35:43 UTC
Change 105511 merged by jenkins-bot:
Fix ItemByTitleHelper site/title combinations.

https://gerrit.wikimedia.org/r/105511

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links