Last modified: 2014-01-09 03:29:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61705, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59705 - Sending an invalid XFF header throws a QueryError
Sending an invalid XFF header throws a QueryError
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GlobalBlocking (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-06 03:34 UTC by Kunal Mehta (Legoktm)
Modified: 2014-01-09 03:29 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2014-01-06 03:34:53 UTC 
Discovered by Skizzerz:

Query: SELECT  *  FROM `globalblocks`  WHERE ()  <br />
Function: GlobalBlocking::checkIpsForBlock<br />
Error: 1064 You have an error in your SQL syntax; check the manual that
corresponds to your MySQL server version for the right syntax to use nea
r ')' at line 1 (localhost)<br />

The function should just check that if $conds === array(), return and not bother executing the query.
Comment 1 Gerrit Notification Bot 2014-01-06 03:40:24 UTC 
Change 105636 had a related patch set uploaded by Legoktm:
Guard against no valid IPs being provided to GlobalBlocking::checkIpsForBlock

https://gerrit.wikimedia.org/r/105636
Comment 2 Gerrit Notification Bot 2014-01-08 23:17:33 UTC 
Change 105636 merged by jenkins-bot:
Guard against no valid IPs being provided to GlobalBlocking::checkIpsForBlock

https://gerrit.wikimedia.org/r/105636
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links