Last modified: 2014-04-22 08:50:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61717, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 59717 - Part of HTML comment tag within Heading appears in Search Results and malformed URL. (Wikimedia→lucene-search2?)


Summary:	Part of HTML comment tag within Heading appears in Search Results and malform...

Status:	RESOLVED WONTFIX

Product:	Wikimedia
Classification:	Unclassified
Component:	lucene-search-2 (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:	cirrus-fixed
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-01-06 13:40 UTC by Peter Halasz
Modified:	2014-04-22 08:50 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshots illustrating the bug (328.48 KB, image/png) 2014-01-06 13:40 UTC, Peter Halasz	Details
Add an attachment (proposed patch, testcase, etc.)

Description Peter Halasz 2014-01-06 13:40:14 UTC

Created attachment 14231 [details]
Screenshots illustrating the bug

On en.wikipedia.org [MediaWiki 1.23wmf8 (019de9e)]


Here's some screenshots which illustrate the issue better (also attached):

http://i.imgur.com/a4PpZ8L.png


If an HTML-style comment <!-- like this --> appears in a ==Heading==, the "-->" may appear in the search results, as well as in search URLs.

Not a huge issue, but may point to underlying issues with the parsing of comments, and should probably be fixed.

Note the search link still went to the right page, but failed to find the heading due to the additional "--.3E" in the URL.

Comment 1 Peter Halasz 2014-01-06 13:42:03 UTC

The search used in the example screenshot is here:

http://en.wikipedia.org/wiki/Special:Search?search=de+Broglie+matter+wave

Comment 2 Nik Everett 2014-01-06 16:20:20 UTC

CirrusSearch doesn't have this trouble.  I've added a regression test to catch it in case it shows up though.

Comment 3 Gerrit Notification Bot 2014-01-06 16:47:28 UTC

Change 105700 had a related patch set uploaded by Manybubbles:
Clean up tests a bit

https://gerrit.wikimedia.org/r/105700

Comment 4 Gerrit Notification Bot 2014-01-06 17:02:01 UTC

Change 105700 merged by jenkins-bot:
Clean up tests a bit

https://gerrit.wikimedia.org/r/105700

Comment 5 Andre Klapper 2014-03-11 16:59:34 UTC

[No patches left for review here; resetting bug status]

Comment 6 Chad H. 2014-04-22 08:50:45 UTC

Issue with lsearchd, moving and wontfixing.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links