Last modified: 2014-02-12 23:47:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61747, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 59747 - initial KeepGoing overlay does not render
initial KeepGoing overlay does not render
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
beta (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-07 00:54 UTC by Ryan Kaldari
Modified: 2014-02-12 23:47 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2014-01-07 00:54:15 UTC 
It looks like the KeepGoing overlay was broken by https://gerrit.wikimedia.org/r/#/c/102043/.

Specifically, that change moved the overlay show() from KeepGoingOverlay::render() to the keepgoing.js instatiation (which only handles the 2nd half of the keepgoing workflow). The first step is handled in EditorOverlay.js (around line 233).

This could either be fixed by adding a show() in EditorOverlay.js or moving show() back into KeepGoingOverlay::render(). Putting it back in KeepGoingOverlay::render() seems the most sensible (after all, that's the function that is supposed to render the overlay). Is there a specific reason it was moved out of that function?
Comment 1 Bingle 2014-01-07 01:00:30 UTC 
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1600
Comment 2 Gerrit Notification Bot 2014-01-07 01:49:48 UTC 
Change 105883 had a related patch set uploaded by Kaldari:
Fix KeepGoing Overlay - step 1

https://gerrit.wikimedia.org/r/105883
Comment 3 Gerrit Notification Bot 2014-01-07 01:54:22 UTC 
Change 105883 merged by jenkins-bot:
Fix KeepGoing Overlay - step 1

https://gerrit.wikimedia.org/r/105883
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links