Last modified: 2014-02-14 23:52:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61749, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59749 - Fix ugly mixed bold styles in Bugzilla fields in Wikimedia skin
Fix ugly mixed bold styles in Bugzilla fields in Wikimedia skin
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-07 02:33 UTC by This, that and the other (TTO)
Modified: 2014-02-14 23:52 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (27.42 KB, image/png)
2014-01-07 02:33 UTC, This, that and the other (TTO)
Details

Description This, that and the other (TTO) 2014-01-07 02:33:55 UTC
Created attachment 14243 [details]
Screenshot

Our local custom Wikimedia skin displays bug field captions with a seemingly random mix of bold and "double-bold" (black) text. See the screenshot (taken in Firefox, but the same output is seem in other browsers).

I think all these text labels, except perhaps the bug number in the header, should just use a regular bold style.
Comment 1 Andre Klapper 2014-01-07 08:51:15 UTC
I guess I have to find some way to reproduce (font settings) because I've never seen this.
Comment 2 This, that and the other (TTO) 2014-01-07 09:00:49 UTC
Probably only occurs with Arial as the default font (this is true on Windows).
Comment 3 This, that and the other (TTO) 2014-01-07 09:10:10 UTC
This is actually an upstream bug in Bugzilla itself - it just never rears its head anywhere else because BZ is not usually displayed in Arial font.

There's no reason why we can't fix it locally, though.
Comment 4 Gerrit Notification Bot 2014-01-07 09:43:10 UTC
Change 105921 had a related patch set uploaded by TTO:
Fix double-bolding of bug field labels with Arial font

https://gerrit.wikimedia.org/r/105921
Comment 5 Andre Klapper 2014-01-07 11:34:10 UTC
Thanks for the patch!

(In reply to comment #0)
> Our local custom Wikimedia skin

(In reply to comment #3)
> This is actually an upstream bug in Bugzilla itself

These two lines feel slightly contradictive. Is this an issue that I should upstream to https://bugzilla.mozilla.org/ or not? Does it also happen if you use "Classic" or "Dust" CSS? Sorry, don't have a Windows machine around now...
Comment 6 This, that and the other (TTO) 2014-01-07 11:44:41 UTC
The bug is arguably caused by some rather loopy and inconsistent HTML and CSS in the global Bugzilla files. But it is never exposed until the page is displayed using Arial (or another font with a "Black" variant).

Since our Wikimedia skin uses the browser's default sans-serif font, which is normally Arial on windows machines, the bug is "exposed" by our local skin. I didn't realise this when I wrote comment 0.

And yes, if you could upstream it, it would be great.
Comment 7 Andre Klapper 2014-01-07 17:15:47 UTC
Probably best to test first on https://landfill.bugzilla.org/bugzilla-tip/ after creating an account there as we still run 4.2 currently.
Comment 8 This, that and the other (TTO) 2014-01-13 11:45:14 UTC
I'm pretty sure this has been fixed upstream, however when we upgrade we will need to fix the modified version of edit.html.tmpl.

In the meantime, the options are either to use this ugly CSS hack, or else to muck around with edit.html.tmpl and potentially other template files (not yet in the modifications repo) to fix the messy HTML.
Comment 9 Gerrit Notification Bot 2014-02-13 09:30:38 UTC
Change 105921 abandoned by TTO:
Fix double-bolding of bug field labels with Arial font

Reason:
No longer relevant with 4.4 upgrade, see bug report

https://gerrit.wikimedia.org/r/105921
Comment 10 This, that and the other (TTO) 2014-02-13 09:31:00 UTC
After the upgrade, all is well, *except* the "Component" label, which is still in extra bold text, and is also missing its trailing colon.

Abandoning the patch as no longer relevant. I'll upload a new patch if I can find the cause of the issue.
Comment 11 Gerrit Notification Bot 2014-02-13 09:43:48 UTC
Change 113095 had a related patch set uploaded by TTO:
Update custom Component label to match 4.4 styling

https://gerrit.wikimedia.org/r/113095
Comment 12 Gerrit Notification Bot 2014-02-14 14:59:47 UTC
Change 113095 merged by Dzahn:
Update custom Component label to match 4.4 styling

https://gerrit.wikimedia.org/r/113095
Comment 13 Daniel Zahn 2014-02-14 15:01:16 UTC
deployed, please confirm
Comment 14 This, that and the other (TTO) 2014-02-14 23:52:17 UTC
Now fixed. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links