Last modified: 2014-01-13 17:26:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61782, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59782 - Cite: Improper state resetting when multiple <references /> tags are present
Cite: Improper state resetting when multiple <references /> tags are present
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-07 19:22 UTC by ssastry
Modified: 2014-01-13 17:26 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2014-01-07 19:22:23 UTC
Both a-tags have identical hrefs, both li-tags have identical about attrs and ids whereas they shouldn't since the hrefs point to different references and ids should be unique on a page.

[subbu@earth lib] echo "X <ref>one</ref> <references />\n\nY <ref>two</ref> <references />" | node parse
<body data-parsoid='{"dsr":[0,65,0,0]}'>X <span about="#mwt3" class="reference" data-mw='{"name":"ref","body":{"html":"one"},"attrs":{}}' id="cite_ref-1-0" rel="dc:references" typeof="mw:Extension/ref" data-parsoid='{"src":"&lt;ref>one&lt;/ref>","dsr":[2,16,5,6]}'><a href="#cite_note-1">[1]</a></span> <ol class="references" typeof="mw:Extension/references" about="#mwt4" data-parsoid='{"src":"&lt;references />","dsr":[17,31,2,2]}' data-mw='{"name":"references","attrs":{}}'><li about="#cite_note-1" id="cite_note-1" data-parsoid="{}"><span rel="mw:referencedBy"><a href="#cite_ref-1-0">↑</a></span> one</li></ol>

Y <span about="#mwt7" class="reference" data-mw='{"name":"ref","body":{"html":"two"},"attrs":{}}' id="cite_ref-1-0" rel="dc:references" typeof="mw:Extension/ref" data-parsoid='{"src":"&lt;ref>two&lt;/ref>","dsr":[35,49,5,6]}'><a href="#cite_note-1">[1]</a></span> <ol class="references" typeof="mw:Extension/references" about="#mwt8" data-parsoid='{"src":"&lt;references />","dsr":[50,64,2,2]}' data-mw='{"name":"references","attrs":{}}'><li about="#cite_note-1" id="cite_note-1" data-parsoid="{}"><span rel="mw:referencedBy"><a href="#cite_ref-1-0">↑</a></span> two</li></ol>
</body>
Comment 1 Arlo Breault 2014-01-09 21:05:18 UTC
Subbu: isn't this "References: 3. ref list should be cleared after processing references"?
Comment 2 ssastry 2014-01-09 23:39:31 UTC
Arlo: yes .. that is the test. It will need updating as well.
Comment 3 Gerrit Notification Bot 2014-01-10 21:18:16 UTC
Change 106772 had a related patch set uploaded by Arlolra:
Properly bump reference anchors

https://gerrit.wikimedia.org/r/106772
Comment 4 Gerrit Notification Bot 2014-01-13 17:24:58 UTC
Change 106772 merged by jenkins-bot:
Properly bump reference anchors

https://gerrit.wikimedia.org/r/106772

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links