Last modified: 2014-02-19 22:22:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61784, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59784 - Flow: display multiple error msg's of errors from the same type
Flow: display multiple error msg's of errors from the same type
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-07 19:40 UTC by Matthias Mullie
Modified: 2014-02-19 22:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Mullie 2014-01-07 19:40:25 UTC
AbstractBlock->addError() accepts $type, $message and $extra.

Error messages are saved in an array with $type as key. Adding multiple errors of the same type will cause these errors to overwrite one another. As a result, only tge last error-of-a-type is displayed.

Implementation idea: we can probably just add an array of errors per type (instead of only 1 error per type) and have getErrorMessage() concatenate all messages & have getErrorExtra() combine all extras (perhaps we have to enforce extra to be an array here)?
Comment 1 Bingle 2014-01-07 23:35:13 UTC
The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/695, but people from the community are welcome to contribute here and in Gerrit.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links