Last modified: 2014-09-25 21:52:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61822, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59822 - VisualEditor: Mouse up outside the surface doesn't register a selection change.
VisualEditor: Mouse up outside the surface doesn't register a selection change.
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-09-18
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-08 15:32 UTC by Ed Sanders
Modified: 2014-09-25 21:52 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2014-01-08 15:32:12 UTC
1. Open up the standalone demo /empty.html and type some text
2. Select text from right to left, mouse up outside the surface (or even outside the window)
3. Although the text is selected in CE pressing dump range gives a collapsed range. Formatting actions will fail too.
Comment 1 Ed Sanders 2014-07-10 18:13:19 UTC
Perhaps we should be using document.onselectionchange to update the model selection (polyfill: https://github.com/2is10/selectionchange-polyfill)
Comment 2 Ed Sanders 2014-07-10 18:25:42 UTC
Or just stop the surface observer from being disabled. We currently have a bug whereby if you create a selection on a blurred document the SO isn't disabled so you can see the range being periodically updated as you change the selection.
Comment 3 Gerrit Notification Bot 2014-09-11 18:53:25 UTC
Change 159807 had a related patch set uploaded by Esanders:
Bound onDocumentMouseUp to the entire document on mousedown

https://gerrit.wikimedia.org/r/159807
Comment 4 Gerrit Notification Bot 2014-09-11 21:37:55 UTC
Change 159807 merged by jenkins-bot:
Bind ve.ce.Surface#onDocumentMouseUp to the entire document on mousedown

https://gerrit.wikimedia.org/r/159807
Comment 5 Gerrit Notification Bot 2014-09-11 22:43:31 UTC
Change 159919 had a related patch set uploaded by Esanders:
Trigger selection update on selectionchange or mousemove events

https://gerrit.wikimedia.org/r/159919
Comment 6 Gerrit Notification Bot 2014-09-12 01:14:34 UTC
Change 159919 merged by jenkins-bot:
Trigger selection update on selectionchange or mousemove events

https://gerrit.wikimedia.org/r/159919
Comment 7 Rummana Yasmeen 2014-09-15 19:54:02 UTC
Verified the fix in Betalabs
Comment 8 Rummana Yasmeen 2014-09-18 23:35:01 UTC
Verified the fix in test2
Comment 9 Rummana Yasmeen 2014-09-25 21:52:30 UTC
Verified the fix in production

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links