Last modified: 2014-09-25 20:24:39 UTC
When a Gerrit change for a bug is abandoned, if the bug is PATCH_TO_REVIEW, Gerrit Notification Bot should change it back to its previous status when it posts the abandonment message.
Just adding a comment that I don't have a strong opinion on this. Jack's point is valid (especially when it comes to the wording TO_REVIEW), but patches might be abandoned also for non-technical reasons (e.g. submitter not interested anymore, or bug 39139 comment 8), and might still make a bug "closer" to getting fixed when somebody picks up the (abandoned) code again.
I agree that the status of bugs for which the only Gerrit change(s) are at a status of Abandoned should not show a status of PATCH_TO_REVIEW. It is deceptive and counter to actually getting the bug resolved. For example, when looking for a bug to start work on would you ever choose to include bugs with the status PATCH_TO_REVIEW in your search results? The reason for the abandonment is not relevant. The effective status is that the bug needs the attention of a developer to begin work on a solution. If it happens that there is code which might be adapted or used as a starting point that is something that the developer can determine by reading the bug. The point is to return such bugs to the point where they are appropriately placed within the Bug management/Bug report life cycle. The way to do that is to remove the effect that having the abandoned Gerrit change is having on the status of the bug.
I would not spend too much time thinking about this, because in a few months we will neither have Bugzilla nor Gerrit anymore if all goes well. :) See https://www.mediawiki.org/wiki/Phabricator
