Last modified: 2014-01-15 07:25:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61865, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59865 - make git-review support pushing via https
make git-review support pushing via https
Status: REOPENED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-09 11:04 UTC by apsdehal
Modified: 2014-01-15 07:25 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description apsdehal 2014-01-09 11:04:43 UTC
Currently, its not possible to push to gerrit using https method.
Since people with internet on which port 29418 is blocked can't access it through ssh, it makes a hard time to contribute, so it would better to have an alternative.
Also git review doesn't work with https.
Comment 2 apsdehal 2014-01-09 11:23:27 UTC
But still it would be easier to push through git-review, and https is not possible with it.
Comment 3 Daniel Zahn 2014-01-09 11:41:46 UTC
I'd like to reopen it because i suggested to create it. reasoning: there are probably quite a few users who are behind firewalls that don't allow them to connect to the high gerrit port. And there seem to be at least some theoretical solutions, like:

 login gerrit-server-host -> settings -> http password -> generate password.

https://groups.google.com/forum/#!topic/repo-discuss/7BXB_t7cHs8

just curious if that has ever been considered before, pls CC: demon
Comment 4 Chad H. 2014-01-09 15:25:52 UTC
(In reply to comment #0)
> Currently, its not possible to push to gerrit using https method.

Yes it is.

> Since people with internet on which port 29418 is blocked can't access it
> through ssh, it makes a hard time to contribute, so it would better to have
> an
> alternative.

That's bug 35611.

> Also git review doesn't work with https.

git-review is awful :(
Comment 5 Daniel Zahn 2014-01-13 17:55:05 UTC
apsdehal,

to summarize, because i also wanted to know this and asked around:

you can push via https using the gerrit feature to set a "http pass", gerrit would let you do this, git let's you do it, the only problem is that the "git review" tool does not support this.  So your workaround is one of:

- don't use git review and use the longer manual git commands instead,
- fix the git review tool itself, which is not part of git core, 
or
- find or write another tool that makes it comfortable to do but does not have this limitation

so this is not a bug against gerrit, but just against the git review tool that we recommend to use, but you don't have to use it.

hope that helped
Comment 6 apsdehal 2014-01-13 18:00:50 UTC
Daniel,

Thanks for your concern, I would look upon and check the http push you said and would look into git review to see if I can fix it.
Comment 8 Marcin Cieślak 2014-01-13 19:43:24 UTC
git-review currently relies heavily on gerrit SSH commands to query some information. We sill have some issues to resolve with it. Adding HTTP support would mean a major rewrite.

See also https://bugs.launchpad.net/git-review/+bug/1194718/comments/6 for some background.

I am pretty sure there was an upstream bug somewhere about it but I can't find it now (daydreaming?)
Comment 9 apsdehal 2014-01-15 07:20:25 UTC
I was able to push my change to existing gerrit repo using the command
git push https://username@gerrit.wikimedia.org/r/mediawiki/extensions/ExtensionName HEAD:refs/changes/[last two digits of gerrit repo no]/repono.

For example:-
If username:- is foo and extension is UploadWizard and repo no. is 123456 do the following

git push https://foo@gerrit.wikimedia.org/r/mediawiki/extensions/UploadWizard HEAD:refs/changes/56/123456

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links