Last modified: 2014-04-14 16:08:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61868, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59868 - VisualEditor: Document selection should be nullable
VisualEditor: Document selection should be nullable
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High enhancement
: VE-deploy-2014-04-17
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-09 15:47 UTC by Ed Sanders
Modified: 2014-04-14 16:08 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ed Sanders 2014-01-09 15:47:53 UTC
Despite the fact that you can have the appearance of the document being blurred and having no active selections, we will always keep the last valid range as the current selection. This is a case of the model not matching the view.

The other solution (as used by Google Docs) is to always render a selection even when the document is unfocused, but as we are using native selections this may not be possible.
Comment 1 James Forrester 2014-03-10 23:30:39 UTC
What's the status of this? Did your work on cursor selections last week relate?
Comment 2 Gerrit Notification Bot 2014-03-27 21:45:04 UTC
Change 121534 had a related patch set uploaded by Esanders:
Detect document focus properly and allow null selection in model

https://gerrit.wikimedia.org/r/121534
Comment 3 Gerrit Notification Bot 2014-04-01 23:24:28 UTC
Change 121534 merged by jenkins-bot:
Detect document focus properly and allow null selection in model

https://gerrit.wikimedia.org/r/121534
Comment 4 Roan Kattouw 2014-04-02 22:27:17 UTC
Was reverted in https://gerrit.wikimedia.org/r/123464
Comment 5 Gerrit Notification Bot 2014-04-07 17:43:39 UTC
Change 124359 had a related patch set uploaded by Esanders:
Detect document focus properly and allow null selection in model

https://gerrit.wikimedia.org/r/124359
Comment 6 Gerrit Notification Bot 2014-04-12 00:19:44 UTC
Change 124359 merged by jenkins-bot:
Detect document focus properly and allow null selection in model

https://gerrit.wikimedia.org/r/124359

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links