Last modified: 2014-02-18 02:27:43 UTC
Initially I was looking at /template/en/custom/global/user-links.html.tmpl and curious why there is no upstream equivalent. Our custom /template/en/custom/global/footer.html.tmpl is in use. It defines the entire left toolbar (and the footer). It processes the following custom files: * /template/en/custom/global/user-links.html.tmpl * /template/en/custom/global/nav-links.html.tmpl * /template/en/custom/global/search-links.html.tmpl In upstream code, /template/en/default/global/footer.html.tmpl processes * /template/en/default/global/useful-links.html.tmpl which in turn processes * * /template/en/default/global/common-links.html.tmpl However, as upstream /template/en/default/global/footer.html.tmpl is the only file calling [% PROCESS "global/useful-links.html.tmpl" %], but as we have replaced upstream footer.html.tmpl by our custom /template/en/custom/global/footer.html.tmpl, this stuff is never called, so we won't see a "Saved Reports" item in the left pane in Bugzilla 4.4 once we have upgraded from 4.2 to 4.4, as <li id="reports-saved"> is defined in /template/en/default/global/useful-links.html.tmpl. We should either port, or (preferably) adapt the upstream structure to minimize the diff here, get new functionality, and improve maintainability.
Table for my diff skills to see what else we've missed over the years: WM UPSTREAM nav-links common-links user-links common-links search-links useful-links
Change 107423 had a related patch set uploaded by Aklapper: [4.4] Update custom search-links so Saved Reports are displayed https://gerrit.wikimedia.org/r/107423
I had https://gerrit.wikimedia.org/r/#/c/106671/3 but abandoned it, per: not worth it anymore in 4.2 if it changes here anyways
This was merged hence closing as FIXED, however bug 61288 is a regression created by this.
Change 113073 had a related patch set uploaded by Aklapper: Fix UI regression in side bar introduced in bug 59889 https://gerrit.wikimedia.org/r/113073
Change 113073 merged by Dzahn: Fix UI regression in side bar introduced in bug 59889 https://gerrit.wikimedia.org/r/113073