Last modified: 2014-02-18 02:27:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61889, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59889 - Clean up custom footer.html.tmpl and adapt upstream's included subpages structure (blocks "saved reports" in 4.4)
Clean up custom footer.html.tmpl and adapt upstream's included subpages struc...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
wmf-deployment
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 61288
  Show dependency treegraph
 
Reported: 2014-01-09 23:31 UTC by Andre Klapper
Modified: 2014-02-18 02:27 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Andre Klapper 2014-01-09 23:31:39 UTC
Initially I was looking at /template/en/custom/global/user-links.html.tmpl and curious why there is no upstream equivalent.

Our custom /template/en/custom/global/footer.html.tmpl is in use.
It defines the entire left toolbar (and the footer).
It processes the following custom files:
* /template/en/custom/global/user-links.html.tmpl
* /template/en/custom/global/nav-links.html.tmpl
* /template/en/custom/global/search-links.html.tmpl

In upstream code,
/template/en/default/global/footer.html.tmpl processes 
* /template/en/default/global/useful-links.html.tmpl 
which in turn processes
* * /template/en/default/global/common-links.html.tmpl

However, as upstream /template/en/default/global/footer.html.tmpl is the only file calling [% PROCESS "global/useful-links.html.tmpl" %], but as we have replaced upstream footer.html.tmpl by our custom /template/en/custom/global/footer.html.tmpl, this stuff is never called, so we won't see a "Saved Reports" item in the left pane in Bugzilla 4.4 once we have upgraded from 4.2 to 4.4, as <li id="reports-saved"> is defined in /template/en/default/global/useful-links.html.tmpl.

We should either port, or (preferably) adapt the upstream structure to minimize the diff here, get new functionality, and improve maintainability.
Comment 1 Andre Klapper 2014-01-14 19:38:42 UTC
Table for my diff skills to see what else we've missed over the years:
WM               UPSTREAM
nav-links        common-links
user-links       common-links
search-links     useful-links
Comment 2 Gerrit Notification Bot 2014-01-14 19:52:05 UTC
Change 107423 had a related patch set uploaded by Aklapper:
[4.4] Update custom search-links so Saved Reports are displayed

https://gerrit.wikimedia.org/r/107423
Comment 3 Daniel Zahn 2014-01-16 15:40:56 UTC
I had https://gerrit.wikimedia.org/r/#/c/106671/3 but abandoned it, per: not worth it anymore in 4.2 if it changes here anyways
Comment 4 Andre Klapper 2014-02-13 01:36:26 UTC
This was merged hence closing as FIXED, however bug 61288 is a regression created by this.
Comment 5 Gerrit Notification Bot 2014-02-13 02:23:32 UTC
Change 113073 had a related patch set uploaded by Aklapper:
Fix UI regression in side bar introduced in bug 59889

https://gerrit.wikimedia.org/r/113073
Comment 6 Gerrit Notification Bot 2014-02-14 20:18:06 UTC
Change 113073 merged by Dzahn:
Fix UI regression in side bar introduced in bug 59889

https://gerrit.wikimedia.org/r/113073

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links