Last modified: 2014-01-18 05:36:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61891, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59891 - VisualEditor: Don't maintain the selection when exiting from an inspector because users don't expect it
VisualEditor: Don't maintain the selection when exiting from an inspector bec...
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Unprioritized minor
: ---
Assigned To: James Forrester
https://sv.wikipedia.org/wiki/Wikiped...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-10 00:18 UTC by Anna Koval
Modified: 2014-01-18 05:36 UTC (History)
7 users (show)

See Also:
Web browser: Apple Safari
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Anna Koval 2014-01-10 00:18:59 UTC
Intention:
If I understand it correctly, the user defines a link target for text. This seems to highlight/mark the text for that user, so if the user then enters a space as the next letter as s/he wants to continue writing, this will overwrite the marked text. Says this happens with Safari 6.1.1 and Firefox 26.0 on OS X 10.7.5 and 10.8.5 (all four combinations). Haven't tried other browsers/operating systems. 

Steps to Reproduce:
1. Tried but could not duplicate this problem in Firefox 26 or Chrome 31
2. 
3. 



Reproducible: Couldn't Reproduce

Andre says: https://bugzilla.wikimedia.org/show_bug.cgi?id=57716 item 2# feels slightly related but not exactly the same.
Comment 1 Andre Klapper 2014-01-10 01:18:34 UTC
For the records: From https://sv.wikipedia.org/wiki/Wikipedia:VisualEditor/%C3%85terkoppling#L.C3.A4nkad_text_blir_markerad_och_f.C3.B6rsvinner

I cannot reproduce in Firefox 26 on Fedora Linux 20 on cs.wikipedia.org - after clicking the "Close" button on the left in the "Link target" dialog the link text is not highlighted for me.
Comment 2 NH 2014-01-10 10:20:07 UTC
Anna Koval got it right, but I'll clarify anyway:

1) Open some page for editing.
2) Type a word that you wish to link to another page.
3) Press Command-K or click at the link tool button.
4) Select or type the name of the target page and press enter twice.
5) When you continue to type the linked word disappears.

If you, at step (4), click at the "Close" button in the link dialog instead of using the Enter key to complete, this does not happen.
Comment 3 Anna Koval 2014-01-10 17:31:22 UTC
Thanks, NH. :) Actually, I was able to reproduce it this time! The text that was to be linked was selected or highlighted so that it could be linked. Pressing enter the first time makes the linking box/window/popup go away. Pressing enter a second time makes the newly-linked text go away. The work around is to click with cursor elsewhere on the page so as to deselect/unhighlight the text. But if this can be fixed code wise, would save everyone one additional click. HTH. :)
Comment 4 James Forrester 2014-01-18 05:36:44 UTC
I don't know about this; this is intentional behaviour to give users the ability to do something further with their selection (often laboriously-made) if they want to, especially for those primarily using keyboard input.

When you click away from the inspector, we move the cursor to where you clicked it. However, if you're using keyboard driving, you might want to adjust the item you just selected and did an action on, e.g. adding bold/etc. styling.

In general, we've designed the editor so that removing the selection using the keyboard needs you to destroy the selection (type over it) or move the cursor with the cursor keys. I don't think we want to move away from this model, so I'm going to mark this as WONTFIX, but I'd be happy to discuss further if people think this is a mistake.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links