Last modified: 2014-03-13 23:55:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61911, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59911 - VisualEditor: TypeError: Cannot call method 'getModel' of null when adding a newline after a new media item
VisualEditor: TypeError: Cannot call method 'getModel' of null when adding a ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-03-06
Assigned To: D Chan
https://www.mediawiki.org/w/index.php...
:
: 61525 61932 62015 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-10 17:27 UTC by Rummana Yasmeen
Modified: 2014-03-13 23:55 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot (245.66 KB, image/png)
2014-01-10 17:27 UTC, Rummana Yasmeen
Details

Description Rummana Yasmeen 2014-01-10 17:27:32 UTC
Created attachment 14282 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE which has some content
2.Add any image from Insert>Media after going to a newline.
3.Save the page
4.Reopen the page
5.Place the cursor in a new line and hit return

Observed Result:
Newline cannot be added , in the console an error appears:
TypeError: outermostNode is null
	

...documentModel,selection.from,'\n');}else{node.traverseUpstream(function(node){if...

load.p...1826Z&* (line 261)

Test Environment: mw.org
Browser: FF 25
OS: MAC OS X 10. 8. 5
Comment 1 James Forrester 2014-01-16 21:03:33 UTC
Seems to be failing to handle enter when in a block slug for some reason… but only on the page re-load.

Line 1675 of ve.ce.Surface.js (in handleEnter) is throwing "TypeError: Cannot call method 'getModel' of null" because  "outermostNode" is null.

ncaught TypeError: Cannot call method 'getModel' of null ve.ce.Surface.js:1675
Comment 2 Gerrit Notification Bot 2014-01-27 17:59:52 UTC
Change 109693 had a related patch set uploaded by Divec:
WIP:Fix handleEnter when not in a splittable node

https://gerrit.wikimedia.org/r/109693
Comment 3 James Forrester 2014-02-27 04:12:49 UTC
*** Bug 61932 has been marked as a duplicate of this bug. ***
Comment 4 James Forrester 2014-02-27 04:13:23 UTC
*** Bug 61525 has been marked as a duplicate of this bug. ***
Comment 5 James Forrester 2014-02-27 19:48:10 UTC
*** Bug 62015 has been marked as a duplicate of this bug. ***
Comment 6 Gerrit Notification Bot 2014-02-28 18:30:29 UTC
Change 109693 merged by jenkins-bot:
Fix handleEnter in nodes that don't split

https://gerrit.wikimedia.org/r/109693
Comment 7 Rummana Yasmeen 2014-03-01 00:39:23 UTC
Verified the fix in betalabs
Comment 8 Rummana Yasmeen 2014-03-07 22:53:34 UTC
Verified the fix in test2.
Comment 9 Rummana Yasmeen 2014-03-13 23:55:58 UTC
Verified the fix in production:https://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/sandbox&veaction=edit

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links