Last modified: 2014-01-17 21:42:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T61939, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 59939 - Flow: a garbled post must not prevent loading its topic or Board
Flow: a garbled post must not prevent loading its topic or Board
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-11 07:10 UTC by spage
Modified: 2014-01-17 21:42 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-11 07:10:38 UTC
When bug 59884 was happening, the garbled cache (or database?) from failed posts meant nobody could view a board or topic, it would fail with
  Missing Posts: {"14":"050de380f7b8f1dc09e4842b2b77e6f9"}
The user would see this in an errorbox at "Earlier posts" if the problematic post was paginated into view, or would just see "Failed to load the requested data" and this exception would be in exception.log.

We fixed that bug so that new posts worked, and Benny manually located and deleted the garbled cache keys so people could view boards again.

But, there are any number of ways a single post might fail to load (see e.g. bug 57987). Flow must load the other posts in the topic and the other nine posts in the board. It should display an errorbox about the missing post in context giving its UUID as above (cute fail icon optional) so the user knows about the missing post (unlike Facebook's "Ehh, go read the other fluff"!), and still log the problem somewhere prominent (card #590?) so operations counts it as a severe problem.

There's a comment in includes/Data/RootPostLoader.php
    // TODO: fake up a pseudo-post to hold the children? At this point in
    // dev its probably a bug we want to see.
    throw new InvalidDataException( 'Missing Posts: ' . json_encode( $missing ), 'fail-load-data' );
but now we mustn't break an entire Flow board in production over one problem post.

Besides the post in bug 59884 I've left a garbled post on test2wiki, at https://test2.wikipedia.org/w/index.php?title=Talk:Flow_QA&workflow=050d915f4ecd5085237590b11c2fa805  Don't clean this up, it's a nice test to verify better handling of this problem.
Comment 1 Bingle 2014-01-11 07:36:28 UTC
The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/713, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2014-01-13 14:43:17 UTC
Change 107151 had a related patch set uploaded by Matthias Mullie:
Create stub post object instead of failing completely

https://gerrit.wikimedia.org/r/107151
Comment 3 Gerrit Notification Bot 2014-01-17 03:38:58 UTC
Change 107151 merged by jenkins-bot:
Create stub post object instead of failing completely

https://gerrit.wikimedia.org/r/107151
Comment 4 Erik Bernhardson 2014-01-17 21:42:33 UTC
merged, will be deployed on the jan 30 train.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links